[MDEV-9794] extended C or C++ style comments scattered through the sources Created: 2016-03-26 Updated: 2016-03-29 Resolved: 2016-03-29 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Compiling |
| Affects Version/s: | 10.1.12, 5.5.48-galera, 10.0.24-galera |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Minor |
| Reporter: | Michael Felt | Assignee: | Sergei Golubchik |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | None | ||
| Environment: |
AIX, xlc (vac) compiler |
||
| Description |
|
After correcting MANY files manually, I went back and reran cmake but prefixed it with
To remove all the
Just one example:
I say minor - because it can be caught with a compiler flag - BUT - if you have a standard that says to use standard /* and */ for comments - there are several to many places where this has not be followed. p.s. to show just one file 10.0.* and 10.1.* issues:
So, at least 80 files in the 10.* truncks
And more than I wanted to edit manually in the 5.5 branch... Michael |
| Comments |
| Comment by Elena Stepanova [ 2016-03-27 ] |
|
Assigned to serg to decide if it's going to be fixed. |
| Comment by Sergei Golubchik [ 2016-03-29 ] |
|
TokuDB is
taking all that into account, I'm closing this as "not a bug". If you have actual compiler failures on AIX with xlc compiler, caused by C++ comments in the C source files — please list them here and I'll reopen the bug report. Thanks! |