[#MDEV-9590] Always print "Engine-independent statistic" warnings and might be filtering columns unintentionally from engines

Warnings like "Engine-independent statistics are not collected for column 'test'" are always printed even the the Engine-independent statistics are not to be updated.

Demonstration
(root@localhost) [(none)]> create database testdatabase;
Query OK, 1 row affected (0.01 sec)

(root@localhost) [(none)]> use testdatabase;
Database changed

(root@localhost) [testdatabase]> create table simple (test blob);
Query OK, 0 rows affected (0.02 sec)

(root@localhost) [testdatabase]> show variables like 'use_stat_tables';
+-----------------+-------+
\| Variable_name \| Value \|
+-----------------+-------+
\| use_stat_tables \| NEVER \|
+-----------------+-------+
1 row in set (0.00 sec)

(root@localhost) [testdatabase]> analyze table simple;
+---------------------+---------+----------+-------------------------------------------------------------------+
\| Table \| Op \| Msg_type \| Msg_text \|
+---------------------+---------+----------+-------------------------------------------------------------------+
\| testdatabase.simple \| analyze \| Warning \| Engine-independent statistics are not collected for column 'test' \|
\| testdatabase.simple \| analyze \| status \| OK \|
+---------------------+---------+----------+-------------------------------------------------------------------+
2 rows in set (0.00 sec)

The warning should not occur when neither PERSISTENT-clause nor use_stat_tables is set.

(get_use_stat_tables_mode(thd) > NEVER ||

         lex->with_persistent_for_clause)

I would suggest this should be wrapped around the patch as well so the warning does not appear.

Also - is the patch actually also filtering columns for the engines themselves? — if so I guess it shouldn't do that either?!

While at it — maybe the should string "Engine-independent statistics collected" should also be internationalized?

[MDEV-9590] Always print "Engine-independent statistic" warnings and might be filtering columns unintentionally from engines Created: 2016-02-19 Updated: 2016-03-21 Resolved: 2016-03-21
Status:	Closed
Project:	MariaDB Server
Component/s:	Admin statements
Affects Version/s:	10.1.11, 10.1.12
Fix Version/s:	10.1.13

[MDEV-9590] Always print "Engine-independent statistic" warnings and might be filtering columns unintentionally from engines Created: 2016-02-19 Updated: 2016-03-21 Resolved: 2016-03-21