[MDEV-9308] Fix build errors with recent gcc (isfinite) Created: 2015-12-21  Updated: 2016-02-29  Resolved: 2016-02-18

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 5.5.47, 10.0.23, 10.1.9
Fix Version/s: 10.0.24, 10.1.12

Type: Bug Priority: Minor
Reporter: Daniel Black Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: patch

Attachments: File isinfinite.patch    
Issue Links:
Relates
relates to MDEV-9527 build FAILs with GCC 5.1 with release... Closed
Sprint: 5.5.48-0

 Description    

mariadb-server/sql/item_func.h:235:26: error: ‘isfinite’ was not declared in this scope
 
mariadb-server/sql/field.cc:2705:19: error: ‘isfinite’ was not declared in this scope



 Comments   
Comment by Daniel Black [ 2015-12-21 ]

include/my_global.h my_isfinite from MySQL-5.7 is worth looking at too.

Comment by Daniel Black [ 2015-12-21 ]

As luck would have it, 5.2 complains if we use std::isfinite():

/home/anton/mariadb-server/sql/item_func.h:235:17: error: expected
unqualified-id before ‘(’ token
return std::isfinite(value) ? value : raise_float_overflow();

And 6.0 complains if we use isfinite():

/home/anton/mariadb-server/sql/item_func.h:235:26: error: ‘isfinite’
was not declared in this scope
return isfinite(value) ? value : raise_float_overflow();

Comment by Sergei Golubchik [ 2016-02-04 ]

Is gcc-6.0 the only compiler that complains about isfinite?
Then I'll wait till the first 6.0 release before fixing this.

Generated at Thu Feb 08 07:33:41 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.