[MDEV-9277] Debian: the Lintian complains about "shlib-calls-exit" in ha_mroonga.so Created: 2015-12-14 Updated: 2023-01-23 Resolved: 2023-01-23 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - Mroonga |
| Affects Version/s: | 10.0, 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Tuukka Pasanen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | mroonga | ||
| Issue Links: |
|
||||||||
| Description |
|
This is a split from Lintian reports: http://labs.seravo.fi/~otto/mariadb-repo/mariadb-10.0-sid-amd64/lintian-0f7cb30.log and https://lintian.debian.org/tags/shlib-calls-exit.html
nm ./storage/mroonga/ha_mroonga.so|grep exit
|
| Comments |
| Comment by Elena Stepanova [ 2022-11-10 ] |
|
The report does not seem to be complaining about mroonga anymore: |
| Comment by Kouhei Sutou [ 2022-11-10 ] |
|
otto Can we close this? |
| Comment by Otto Kekäläinen [ 2022-11-13 ] |
|
I don't see any Lintian overrides about {shlib-calls-exit}in https://salsa.debian.org/mariadb-team/mariadb-server/-/blob/debian/latest/debian/source/lintian-overrides nor complaints about this specific issue in latest Lintian report at https://mariadb-team.pages.debian.net/-/mariadb-server/-/jobs/3505163/artifacts/debian/output/lintian.html If illuusio agrees that this issue is either already fixed or has become obsolete, then feel free to close issue. Note that there are other Lintian remarks about Mroonga still. |
| Comment by Tuukka Pasanen [ 2023-01-23 ] |
|
I'll check this and close if there is no exit anymore. |
| Comment by Tuukka Pasanen [ 2023-01-23 ] |
|
C exit still is there examined with objdump and I examined other storage engines (10.10):
|
| Comment by Tuukka Pasanen [ 2023-01-23 ] |
|
There is several exit-functios used even in 10.3. They should be check are they causing problems. |
| Comment by Tuukka Pasanen [ 2023-01-23 ] |
|
In MRoonga exit is inside function segv_handler which is only called when there is memory handling problem. On Connect there is exit function tabrest.cpp but it's not build default and exit probably comes from libxml2 (which should not be there but it is) as it does not exit libmysqlservices.a or zlib libz.so. There is newer JIRA task for this MDEV-30432 my_rocks has exit on ha_rocks.cc |
| Comment by Tuukka Pasanen [ 2023-01-23 ] |
|
There is nothing to be done. In mroonga there is signal handler but it's only used if build with:
In RocksDB is kind of builded in option if one has `rocksdb_allow_to_start_after_corruption` set to false then it should not start MariaDB server. Connect should be handled in other JIRA task. Which has been already opened. |