[MDEV-9188] Split Column_definition::check() into virtual methods in Type_handler Created: 2015-11-25  Updated: 2019-04-23  Resolved: 2017-05-16

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Fix Version/s: 10.3.1

Type: Task Priority: Major
Reporter: Alexander Barkov Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: datatype, refactoring

Issue Links:
Blocks
blocks MDEV-4912 Data type plugin API version 1 Closed
Duplicate
is duplicated by MDEV-9396 Split Create_field::init() into virtu... Closed

 Description   

To make the code look the same for the buili-in and pluggable data types, we'll split Column_definition::check(THD*) and move data type specific code into a new virtual method on Type_handler:

virtual bool Type_handler::Column_definition_fix_attributes(Column_definition *);



 Comments   
Comment by Federico Razzoli [ 2016-10-08 ]

Will this have any consequences from a user point of view?

Comment by Alexander Barkov [ 2016-10-10 ]

No, it's an internal change.

Comment by Alexander Barkov [ 2017-05-16 ]

Pushed to bb-10.2-ext

Generated at Thu Feb 08 07:32:48 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.