[MDEV-9117] Client Server capability negotiation for MariaDB specific functionality Created: 2015-11-11  Updated: 2016-02-02  Resolved: 2016-02-02

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Fix Version/s: 10.2.0

Type: Task Priority: Major
Reporter: Oleksandr Byelkin Assignee: Oleksandr Byelkin
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-9058 protocol: COM_MULTI command Closed
Sprint: 10.2.0-1, 10.2.0-5

 Description   

Add yet another 4 bytes of capability flags for new MariaDB functionality:

  • from server->client in handshake packet V1
    • client parse version info to be sure that it is MariaDB server
    • server put flags in last 4 of unused 10 (bytes 14-17)
  • from client->server (only if server mariadb and version is >= 10.2) V1
    • client sets 'client_long_password=0' and 'client_protocol_41=1'
    • puts flag in last 4 of 23 unused

Move CLIENT_PROGRESS flag to the new flag space.

 Comments   
Comment by Sergei Golubchik [ 2015-11-20 ]

also redefine as

#define CLIENT_LONG_PASSWORD 0
 
#define CLIENT_MYSQL 1

Comment by Oleksandr Byelkin [ 2015-11-21 ]

I decide do not touch CLIENT_LONG_PASSWORD because it used by mysqlbinlog (for example) without 41 protocol

revision-id: 2606b8744404f352b44c85ee23d41b12cddc3470 (mariadb-10.1.8-51-g2606b87)
parent(s): 81e4ce5e31ba0753d7acfab28bc6c3d83bfad1c6
committer: Oleksandr Byelkin
timestamp: 2015-11-20 18:23:52 +0100
message:

MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

New capability flags space.
Moved progress flag
fixed mysql_client_test.c

—

Comment by Oleksandr Byelkin [ 2015-11-26 ]

revision-id: cae19452eec1d3be47fa04759dd2dda6d061543e (mariadb-10.1.8-69-gcae1945)
parent(s): 55e67c3e344317c6f349f5391e5d117ec51ae062
committer: Oleksandr Byelkin
timestamp: 2015-11-25 18:09:39 +0100
message:

MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

New capability flags space.
Removed old progress flag, added new one.

—

Comment by Oleksandr Byelkin [ 2016-01-28 ]

revision-id: 5dd6eb45c418f61c749a7884d7b3e13d62f3bfb9 (mariadb-10.1.8-113-g5dd6eb4)

Comment by Oleksandr Byelkin [ 2016-02-02 ]

revision-id: 910576544ea45c5c0446b5da46b4ac0550621787 (mariadb-10.1.8-113-g9105765)
parent(s): 14d79a5e99f9992cabb7489203989ccdaacadb78
committer: Oleksandr Byelkin
timestamp: 2016-02-01 23:07:11 +0100
message:

MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

New capability flags space.
Removed old progress flag, added new one.

—

Comment by Sergei Golubchik [ 2016-02-02 ]

ok to push

Generated at Thu Feb 08 07:32:15 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.