[MDEV-9034] Test skipped due to incorrect end-of-line in .require files Created: 2015-10-28 Updated: 2017-09-25 Resolved: 2017-09-25 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Tests |
| Affects Version/s: | 5.5, 10.0, 10.1 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Major |
| Reporter: | Vladislav Vaintroub | Assignee: | Sergei Golubchik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Windows, git |
||
| Description |
|
After building MariaDB on Windows, trying to run pool_of_threads test gives me main.pool_of_threads [ skipped ] Test requires: 'have_pool_of_threads' Checked in debugger, pool-of-threads is used. Changed line endings in have_pool_of_threads.require from CRLF to LF, gave me a new one main.pool_of_threads [ skipped ] Test requires: 'not_staging' after fixing not_staging.require, the test finally run Some other tests are skipped, with "requires : have_log_bin" Somehow it works on buildbot, would be nice to be able to run all tests on any other Windows box, too. Suspect git/EOL issue. |
| Comments |
| Comment by Elena Stepanova [ 2015-10-28 ] |
|
It works in buildbot because we ran git config --global core.autocrlf input manually there. |
| Comment by Vladislav Vaintroub [ 2015-10-28 ] |
|
Maybe related to |
| Comment by Vladislav Vaintroub [ 2015-10-28 ] |
|
I confirm that git config --global core.autocrlf input solves the issue. If there is a g trick that avoids the need for extra configuration for git on every Windows machine, I'd prefer to use that, Otherwise, the git config step should be documented here https://mariadb.com/kb/en/mariadb/Building_MariaDB_on_Windows/ |
| Comment by Elena Stepanova [ 2015-10-28 ] |
|
Please document it while it's fresh in your head. If it turns out later there is a better solution, we can always remove it. |
| Comment by Sergei Golubchik [ 2017-09-25 ] |
|
We're using .gitattributes for a while now, it should convert crlf's properly |