[MDEV-9012] Do some manual testing for MDEV-8498 Created: 2015-10-26  Updated: 2015-10-28  Resolved: 2015-10-28

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients, Tests
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Elena Stepanova Assignee: Elena Stepanova
Resolution: Done Votes: 0
Labels: None


 Description   

<svoj> elenst: Hi! It would be nice if you could do some extra testing for https://mariadb.atlassian.net/browse/MDEV-8498 Though I did some, this script is not covered by mtr



 Comments   
Comment by Elena Stepanova [ 2015-10-28 ]

Apparently, the previous version aimed to be able to handle the situation when you run mysql_secure_installation from inside the basedir. E.g. you have
basedir/bin/mysql_secure_installation
basedir/bin/mysql
basedir/bin/my_print_defaults
you do
cd basedir
and you run
./bin/mysql_secure_installation
Naturally, basedir/bin is not on the path, and you did not provide --basedir.
So, it would search in ./bin and ideally, would find stuff there; only this logic did not work anyway. Now it's gone, and if there is no basedir, the script immediately defaults to the bindir which was set by cmake.

On the other hand, I cannot think of a case when this intermediate logic would actually be useful for practical purposes.
If it's a source build, there will be no ./bin dir, all stuff is in ./scripts or ./client or ./sql, so it would not work..
If it's an installed build, then the cmake's bindir is just as good.

Comment by Elena Stepanova [ 2015-10-28 ]

Source build/installation – looks ok after a quick sanity check.

Comment by Elena Stepanova [ 2015-10-28 ]

Centos7, Debian Jessie installation – looks ok after a quick check for regressions

Comment by Elena Stepanova [ 2015-10-28 ]

Quick check did not reveal any issues. It's possible that there are configurations that I did not consider, apparently we will have to rely on community testing for those.

Generated at Thu Feb 08 07:31:28 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.