[MDEV-8923] [PATCH] port innodb_buffer_pool_dump_pct + have buffer pool dump and reload set as default Created: 2015-10-09 Updated: 2015-12-17 Resolved: 2015-12-15 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB, Storage Engine - XtraDB |
| Fix Version/s: | 10.0.23 |
| Type: | Task | Priority: | Major |
| Reporter: | Guillaume Lefranc | Assignee: | Jan Lindström (Inactive) |
| Resolution: | Fixed | Votes: | 9 |
| Labels: | patch, upstream-fixed | ||
| Issue Links: |
|
||||||||||||
| Description |
|
Hello, innodb_buffer_pool_dump_at_shutdown and innodb_buffer_load_at_startup are now set to ON by default in 5.7. I think it would be reasonable to have this setting as default as well in 10.1. Thanks |
| Comments |
| Comment by Rick James (Inactive) [ 2015-10-09 ] |
|
Before long we will be seeing terabyte buffer_pools. Reloading such will be (1) time consuming, and (2) well into "diminishing returns". Suggest a new feature that says "Reload the hottest N% of the buffer pool". This way, you could get the most useful pages (eg, upper-level nodes in indexes) reloaded without spending a lot of time on the "long tail". |
| Comment by VAROQUI Stephane [ 2015-10-10 ] |
|
+1 |
| Comment by Daniel Black [ 2015-10-11 ] |
|
looks good maps to what mysql are doing in 5.7. I thought their tradeoff of setting innodb_buffer_pool_dump_pct=25 was good (but it looks like mariadb doesn't have this setting). |
| Comment by Guillaume Lefranc [ 2015-10-18 ] |
|
MariaDB 10.1 is based on InnoDB 5.6, I guess we'll probably have this feature (thanks for mentioning that it exists) in MariaDB 10.2 which will import InnoDB 5.7, without having to implement anything on MariaDB side. |
| Comment by Daniel Black [ 2015-11-29 ] |
|
Ported the innodb_buffer_pool_dump_pct variable. Patch wasn't intrusive (dumped buffer pool in different order) and also included io throttling (was in same upstream commit). Default of innodb_buffer_pool_dump_pct is still 100% to map to existing 10.1 behaviour. |
| Comment by Daniel Black [ 2015-11-29 ] |
|
figured |
| Comment by Jan Lindström (Inactive) [ 2015-12-15 ] |
|
commit b63bf7368b4881789bef931f90d4719b358cf507 Backport pull request #125 from grooverdan/ WL#6504 InnoDB buffer pool dump/load enchantments This patch consists of two parts: 1. Dump only the hottest N% of the buffer pool(s) From MySQL - commit b409342c43ce2edb68807100a77001367c7e6b8e Add testcases for innodb_buffer_pool_dump_pct_basic. Part of the code authored by Daniel Black |
| Comment by Daniel Black [ 2015-12-17 ] |
|
thanks jplindst |