[MDEV-8718] Obsolete sql_strmake() in favor of THD::strmake() and thd_strmake() Created: 2015-09-01 Updated: 2015-11-26 Resolved: 2015-11-26 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | OTHER |
| Fix Version/s: | 10.2.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Sergey Vojtovich |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Epic Link: | Performance: micro optimizations |
| Sprint: | 10.2.0-1 |
| Description |
|
Obsolete sql_strmake() in favor of THD::strmake() and thd_strmake() Since sql_strmake() doesn't have THD parameter, it has to retrieve THD::mem_root by calling relatively expensive pthread_getspecific(THR_MALLOC). This can be optimized easily by modifying server to use THD::strmake() and modifying plugins to use thd_strmake(). |
| Comments |
| Comment by Sergey Vojtovich [ 2015-11-18 ] |
|
serg, please review patch for this task. Note: I had to add 2 current_thd calls to avoid adding thd parameter to Item::val_str(). |
| Comment by Sergei Golubchik [ 2015-11-20 ] |
|
ok to push |