[MDEV-8638] REVOKE ALL PRIVILEGES, GRANT OPTION FROM CURRENT_ROLE breaks replication Created: 2015-08-17  Updated: 2016-06-24  Resolved: 2016-06-24

Status: Closed
Project: MariaDB Server
Component/s: Admin statements, Replication
Affects Version/s: 10.0, 10.1
Fix Version/s: 10.0.26, 10.1.15

Type: Bug Priority: Major
Reporter: Elena Stepanova Assignee: Vicențiu Ciorbaru
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-5164 Testing Roles Closed
Sprint: 10.0.25, 10.0.26

 Description   

Replication has some magic that (normally) allows to work correctly with such functions as CURRENT_USER and CURRENT_ROLE (see MDEV-8628, MDEV-8631). However, for REVOKE ALL PRIVILEGES, GRANT OPTION FROM CURRENT_ROLE this magic fails.

Test case

 
--source include/master-slave.inc
 
--source include/have_binlog_format_mixed.inc
 
 
 
--enable_connect_log
 
 
 
create role r1;
 
set role r1;
 
grant select on db.* to current_role;
 
revoke all privileges, grant option from current_role;
 
 
 
--sync_slave_with_master
 

Last_SQL_Errno	1269
 
Last_SQL_Error	Error 'Can't revoke all privileges for one or more of the requested users' on query. Default database: 'test'. Query: 'revoke all privileges, grant option from current_role'



 Comments   
Comment by Vicențiu Ciorbaru [ 2016-06-20 ]

Hi Sergei!

Can you please review a patch for this bug?

http://lists.askmonty.org/pipermail/commits/2016-June/009470.html

While you look at it, can you also look at time_zone_str initialisation, right above the changed lines? I feel we have to do the same thing there. There is also a comment questioning the validity of that if statement.

Thanks,
Vicentiu

Comment by Vicențiu Ciorbaru [ 2016-06-24 ]

Fixed with
b449612

Generated at Thu Feb 08 07:28:40 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.