[MDEV-8579] Some sysvars in I_S are missing any meaningful help (comment) text Created: 2015-08-07  Updated: 2017-08-15  Resolved: 2017-08-15

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Affects Version/s: 10.1
Fix Version/s: 10.1.27

Type: Bug Priority: Minor
Reporter: Elena Stepanova Assignee: Ian Gilfillan
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-6138 show sysvar's help in I_S tables Closed

 Description   

   variable_name: AUTOCOMMIT
variable_comment: autocommit
 
   variable_name: DELAY_KEY_WRITE
variable_comment: Type of DELAY_KEY_WRITE
 
   variable_name: FOREIGN_KEY_CHECKS
variable_comment: foreign_key_checks
 
   variable_name: HAVE_COMPRESS
variable_comment: have_compress
 
   variable_name: HAVE_CRYPT
variable_comment: have_crypt
 
   variable_name: HAVE_DYNAMIC_LOADING
variable_comment: have_dynamic_loading
 
   variable_name: HAVE_GEOMETRY
variable_comment: have_geometry
 
   variable_name: HAVE_OPENSSL
variable_comment: have_openssl
 
   variable_name: HAVE_PROFILING
variable_comment: have_profiling
 
   variable_name: HAVE_QUERY_CACHE
variable_comment: have_query_cache
 
   variable_name: HAVE_RTREE_KEYS
variable_comment: have_rtree_keys
 
   variable_name: HAVE_SSL
variable_comment: have_ssl
 
   variable_name: HAVE_SYMLINK
variable_comment: have_symlink
 
   variable_name: PROFILING
variable_comment: profiling
 
   variable_name: SKIP_REPLICATION
variable_comment: skip_replication
 
   variable_name: SQL_AUTO_IS_NULL
variable_comment: sql_auto_is_null
 
   variable_name: SQL_BIG_SELECTS
variable_comment: sql_big_selects
 
   variable_name: SQL_BUFFER_RESULT
variable_comment: sql_buffer_result
 
   variable_name: SQL_LOG_OFF
variable_comment: sql_log_off
 
   variable_name: SQL_NOTES
variable_comment: sql_notes
 
   variable_name: SQL_QUOTE_SHOW_CREATE
variable_comment: sql_quote_show_create
 
   variable_name: SQL_SAFE_UPDATES
variable_comment: sql_safe_updates
 
   variable_name: SQL_WARNINGS
variable_comment: sql_warnings
 
   variable_name: TIME_ZONE
variable_comment: time_zone
 
   variable_name: UNIQUE_CHECKS
variable_comment: unique_checks
 
   variable_name: VERSION_COMMENT
variable_comment: version_comment
 
   variable_name: VERSION_COMPILE_MACHINE
variable_comment: version_compile_machine
 
   variable_name: VERSION_COMPILE_OS
variable_comment: version_compile_os
 
   variable_name: WSREP_NOTIFY_CMD
variable_comment: 
 
   variable_name: WSREP_PATCH_VERSION
variable_comment: wsrep patch version

Also, some comments end with a period, it's not harmful, just looks wrong.

Example

   variable_name: TX_READ_ONLY
variable_comment: Set default transaction access mode to read only.



 Comments   
Comment by Sergey Vojtovich [ 2017-08-10 ]

greenman, would you like to take over this task? It is mostly about synchronising "Server System Variables" into sql/sys_vars.cc. Not a big deal, but you may have better idea of how things should be spelled properly.

Comment by Ian Gilfillan [ 2017-08-10 ]

Any objections to adding full stops to all sentences? Some comments have to have full stops as there are multiple sentences, and then not ending with a full stop looks odd.

Comment by Elena Stepanova [ 2017-08-10 ]

To me personally it looks odd having full stops at the end of things like that (error messages, short descriptions, bug summaries, email subjects, etc.); but maybe it's just me. If it's a normal good practice, I will certainly learn to live with it.

Generated at Thu Feb 08 07:28:12 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.