[MDEV-8551] [PATCH] compilation fails with 10.1.6 Created: 2015-07-27  Updated: 2015-10-29  Resolved: 2015-10-29

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.1.6
Fix Version/s: 10.1.9

Type: Bug Priority: Critical
Reporter: Giuseppe Maxia Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: patch
Environment:

OSX 10.10.4
gcc (GCC) 4.9.0 20140309


Sprint: 10.1.9-1

 Description   

I have attempted to install MariaDB 10.1.6, using this command (which worked for previous releases):

cmake . -DBUILD_CONFIG=mysql_release

But after a while I get this error

[ 67%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/command.c.o
[ 67%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/ctx.c.o
[ 67%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/ctx_impl_mrb.c.o
[ 67%] Building CXX object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/dat.cpp.o
/Users/dummy/install/build/mariadb-10.1.6/storage/mroonga/vendor/groonga/lib/dat.cpp:191:3: error: cannot use 'try' with exceptions disabled
  try {
  ^
/Users/dummy/install/build/mariadb-10.1.6/storage/mroonga/vendor/groonga/lib/dat.cpp:222:3: error: cannot use 'try' with exceptions disabled
  try {
  ^
/Users/dummy/install/build/mariadb-10.1.6/storage/mroonga/vendor/groonga/lib/dat.cpp:423:3: error: cannot use 'try' with exceptions disabled
  try {
  ^



 Comments   
Comment by Elena Stepanova [ 2015-07-28 ]

Kentoku, svoj,
Is Mroonga supposed to be supported on OSX?

Comment by Sergei Golubchik [ 2015-07-28 ]

This must be something specific to gcc-4.9 on OSX.

We build 10.1 with gcc 4.9 (for example, on Debian sid) and we build 10.1 on OSX with gcc (but with 4.2.1). Everything builds fine in both cases.

Comment by Giuseppe Maxia [ 2015-07-28 ]

The same commands used for 10.1.6 can compile without errors for 10.1.5

I am using these source tarballs:
MD5 (mariadb-10.1.5.tar.gz) = c6315c39d068aa4e88cb502cdaa51dc8
MD5 (mariadb-10.1.6.tar.gz) = 431031e34223d1ec5e21aed67a0e7990

cmake . -DBUILD_CONFIG=mysql_release && make && ./scripts/make_binary_distribution

Comment by Sergei Golubchik [ 2015-07-28 ]

Yes, because Mroonga was disabled in 10.1.5 and below. 10.1.6 is the first version where Mroonga is enabled (see MDEV-7246). You can disable it in your builds as a workaround.

Comment by Dan [ 2015-07-29 ]

Not sure, if this fully applies to this, problem. But it seems related. Here is a fix (patch at the end of the pull request) for building mroonga with clang(++).

https://github.com/Homebrew/homebrew/pull/42233

Comment by Giuseppe Maxia [ 2015-07-29 ]

@Dan,
your patch solved my problem.
Thanks

Comment by Daniel Black [ 2015-08-08 ]

Dan thanks - did PR for mariadb https://github.com/MariaDB/server/pull/89

Comment by Sergey Vojtovich [ 2015-10-28 ]

serg, I can see you fixed this in 10.0 a while ago, but not in 10.1 for some reason. Github revision: https://github.com/MariaDB/server/commit/66fd45afce1ba5e1032c32cc891c09d64fa38d9e

What should we do with this bug?

Comment by Sergei Golubchik [ 2015-10-28 ]

Perhaps it was removed by Mroonga developers when merging 10.1-Mroonga? I think we can add it back.

Generated at Thu Feb 08 07:28:00 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.