[MDEV-8546] Cleanup: remove st_plugin_int reference indirection Created: 2015-07-27  Updated: 2015-09-13  Resolved: 2015-09-13

Status: Closed
Project: MariaDB Server
Component/s: Plugins
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Sergey Vojtovich Assignee: Sergei Golubchik
Resolution: Won't Fix Votes: 0
Labels: None

Sprint: 10.1.8-1

 Description   

This is pure cleanup, no change in behavior.



 Comments   
Comment by Sergey Vojtovich [ 2015-07-27 ]

serg, please review patch for this task.

Comment by Sergei Golubchik [ 2015-09-13 ]

I don't think it's something worth fixing. It works, doesn't create any problems, really. I'd rather keep it.

And it has that interesting property that plugin_lock() returns a pointer, and that pointer must be used when unlocking a plugin. This is very different from mutex locks, where you always lock and unlock the same (mutex) pointer.

as usual, feel free to comment or reopen, if you disagree

Comment by Sergey Vojtovich [ 2015-09-13 ]

At least a few times I had to spend extra hour or so to track down this code. So far I couldn't justify this indirection for myself.

What's the value of this interesting property you're referring to?

But since I'm alone here, let's keep it.

Generated at Thu Feb 08 07:27:57 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.