[MDEV-8512] main.pool_of_threads fails on WIndows Created: 2015-07-21  Updated: 2015-11-06  Resolved: 2015-11-06

Status: Closed
Project: MariaDB Server
Component/s: Platform Windows, Tests
Affects Version/s: 10.0, 10.1
Fix Version/s: 10.0.23, 10.1.9

Type: Bug Priority: Major
Reporter: Elena Stepanova Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-7069 Fix buildbot failures in main server ... Stalled
Problem/Incident
is caused by MDEV-8669 MTR client connections on Windows bec... Closed
Sprint: 10.1.9-2

 Description   

http://buildbot.askmonty.org/buildbot/builders/win64-release2/builds/7467/steps/test/logs/stdio

main.pool_of_threads                     [ retry-fail ]
        Test ended at 2015-07-20 10:39:33
 
CURRENT_TEST: main.pool_of_threads
--- C:/bzr/bb-win32/win64-release/build/mysql-test/r/pool_of_threads.result	2015-07-20 09:54:53.563036000 -0700
+++ C:\bzr\bb-win32\win64-release\build\mysql-test\r\pool_of_threads.reject	2015-07-20 10:39:32.901145800 -0700
@@ -2159,7 +2159,7 @@
 SET optimizer_switch=@save_optimizer_switch;
 SELECT sleep(5.5);
 SELECT sleep(5);
-# -- Success: more than --thread_pool_max_threads normal connections not possible
+# -- Error: managed to establish more than --thread_pool_max_threads connections
 sleep(5.5)
 0
 sleep(5)
 
mysqltest: Result length mismatch

It started happening from commit a453a280403faef3377db0441560c57b4ae1235b

Author: Sergei Golubchik <serg@mariadb.org>
Date:   Sun Jun 14 17:34:08 2015 +0200
 
    MDEV-8083 MTR is broken on systems with IPv6 disabled
    
    disable IPv6 globally in mysql-test, only use it
    in dedicated IPv6 tests (where it is enabled per-test)

Particularly, this diff:

diff --git a/mysql-test/include/default_mysqld.cnf b/mysql-test/include/default_mysqld.cnf
index 3388166..0432147 100644
--- a/mysql-test/include/default_mysqld.cnf
+++ b/mysql-test/include/default_mysqld.cnf
@@ -31,6 +31,7 @@ debug-no-sync
 
 # Retry bind as this may fail on busy server
 port-open-timeout=10
+bind-address=127.0.0.1
 
 log-bin-trust-function-creators=1
 key_buffer_size=            1M



 Comments   
Comment by Elena Stepanova [ 2015-10-13 ]

FYI wlad

Comment by Vladislav Vaintroub [ 2015-10-29 ]

The test executes "select sleep(5)" on 2 connections and attempts to create a 3rd connection in parallel. It should fail because the maximum number of threads in pool is set to 2.
However MDEV-8669, connect takes much longer time, and the 3rd connection is actually created after the sleep() is finished. connect-timeout is set for the client, however is appears to be ignored on Windows currently (see my_connect() implementation)

Comment by Sergei Golubchik [ 2015-10-29 ]

Wow, nice, thanks! So it'll go away when we fix MDEV-8669, I suppose.

Comment by Vladislav Vaintroub [ 2015-11-06 ]

Fixed with MDEV-8669

Generated at Thu Feb 08 07:27:42 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.