[MDEV-8376] Debian: build log scanner complains about some warnings Created: 2015-06-25 Updated: 2021-09-07 Resolved: 2021-09-06 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | N/A |
| Affects Version/s: | 10.0 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Trivial |
| Reporter: | Sergey Vojtovich | Assignee: | Daniel Black |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Description |
|
The Debian build log scanner complains about some warnings it finds There're 3 distinct errors:
|
| Comments |
| Comment by Sergey Vojtovich [ 2015-07-01 ] | ||||||||||||||||
|
serg, a warning referred as dpkg-buildflags-missing is about missing "-fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security". You added most of these flags in 10.1. Is it reasonable to backport it to 10.0? otto, if we consider this risky to backport to 10.0, you may have to add these flags to debian build scripts to fix this warning. compiler-flags-hidden is most probably false positive. But it is hard to say until dpkg-buildflags-missing is fixed. | ||||||||||||||||
| Comment by Sergey Vojtovich [ 2015-07-01 ] | ||||||||||||||||
|
shlibs-symbol-not-found happens on ARM, which I believe is not among of our supported platforms. I'd fix it anyway, but we have no ARM for debugging. | ||||||||||||||||
| Comment by Sergei Golubchik [ 2015-07-24 ] | ||||||||||||||||
|
compiler-flags-hidden is false positive. Running blhc manually yields
This is, obviously, a blhc bug. Real compiler lines for these files come later in the log. | ||||||||||||||||
| Comment by Sergei Golubchik [ 2015-07-24 ] | ||||||||||||||||
|
dpkg-buildflags-missing looks like a packaging issue? Somehow Debian hardening flags aren't passed down to the compiler. Our cmake files certainly don't strip these flags away. | ||||||||||||||||
| Comment by Sergei Golubchik [ 2015-07-24 ] | ||||||||||||||||
|
shlibs-symbol-not-found looks suspiciously similar to a documented dpkg-shlibdeps bug. Quoting https://qa.debian.org/bls/bytag/W-shlibs-symbol-not-found.html
And we have the warning about __aeabi_atexit@CXXABI_ARM_1.3.3 on armel and armhf. | ||||||||||||||||
| Comment by Sergei Golubchik [ 2015-07-24 ] | ||||||||||||||||
|
Conclusion: these all are downstream (Debian) packaging issues, no upstream (MariaDB) changes are needed. | ||||||||||||||||
| Comment by Otto Kekäläinen [ 2016-11-25 ] | ||||||||||||||||
|
Current complaints are:
(from https://qa.debian.org/bls/packages/m/mariadb-10.0.html) | ||||||||||||||||
| Comment by Daniel Black [ 2021-09-06 ] | ||||||||||||||||
|
current: https://qa.debian.org/bls/packages/m/mariadb-10.5.html agree compiler-flags-hidden is a packaging issue. cmake can expose verbose logs and it doesn't look particularly obscured. shlib-symbols-not-found occurs on unsupported arm architectures. They still references __aeabi_atexit@CXXABI_ARM_1.3.3. probably relates is: related to the two instances of atexit in the codebase:
As its an internal function, it look like you should just compile with -fuse-cxa-atexit on these platforms. | ||||||||||||||||
| Comment by Daniel Black [ 2021-09-07 ] | ||||||||||||||||
|
compiler-flags-hidden might also be, based one the output Sergei observed years ago, mitigated by using cmake --build . --verbose (using tools like they designed and documented, very radical). This, like make --output-sync=target, keeps the output of the compile output to one complete step rather than letting multiple compile processes write to the same stdout. |