[MDEV-8301] Test failures in rpl.rpl_000011 Created: 2015-06-11 Updated: 2023-12-11 Resolved: 2023-12-11 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Replication, Tests |
| Affects Version/s: | 10.0.20, 10.1.6 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Major |
| Reporter: | Kristian Nielsen | Assignee: | Michael Widenius |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 10.1.6-2, 10.0.21 |
| Description |
|
rpl.rpl_000011 'row' w1 [ fail ] CURRENT_TEST: rpl.rpl_000011 mysqltest: Result content mismatch Fails sporadically, but on many hosts. |
| Comments |
| Comment by Kristian Nielsen [ 2015-06-11 ] | ||||||||||||||||||||||||||||||||||||||||
|
So this turns out to actually be an old bug. The race is that there is a small window where SHOW GLOBAL STATUS may count Here is a test case for latest 10.0, triggers with the following sleep
The first SHOW GLOBAL STATUS counts the thread twice:
| ||||||||||||||||||||||||||||||||||||||||
| Comment by Kristian Nielsen [ 2015-06-11 ] | ||||||||||||||||||||||||||||||||||||||||
|
The race occurs because there is a window of time between a thread does THD::add_status_to_global() and THD::unlink(). During this window, calc_sum_of_all_status() can run and count the contribution of the thread twice. | ||||||||||||||||||||||||||||||||||||||||
| Comment by Kristian Nielsen [ 2015-06-11 ] | ||||||||||||||||||||||||||||||||||||||||
|
The original buildbot test failure can be reproduced easily by injecting the
| ||||||||||||||||||||||||||||||||||||||||
| Comment by Kristian Nielsen [ 2015-06-11 ] | ||||||||||||||||||||||||||||||||||||||||
|
Monty said he would fix this during this week | ||||||||||||||||||||||||||||||||||||||||
| Comment by Kristian Nielsen [ 2015-06-15 ] | ||||||||||||||||||||||||||||||||||||||||
|
Monty, I've pushed a temporary work-around for the test failure in rpl.rpl_000011: http://lists.askmonty.org/pipermail/commits/2015-June/008039.html Please remove that work-around from the testcase when you push the fix for this underlying issue. | ||||||||||||||||||||||||||||||||||||||||
| Comment by Michael Widenius [ 2015-06-26 ] | ||||||||||||||||||||||||||||||||||||||||
|
Fixed by adding a marker if we have added the thread counters to the global counters. | ||||||||||||||||||||||||||||||||||||||||
| Comment by Michael Widenius [ 2015-06-26 ] | ||||||||||||||||||||||||||||||||||||||||
|
Fix pushed into 5.5 | ||||||||||||||||||||||||||||||||||||||||
| Comment by Julien Fritsch [ 2023-12-05 ] | ||||||||||||||||||||||||||||||||||||||||
|
Automated message: | ||||||||||||||||||||||||||||||||||||||||
| Comment by Kristian Nielsen [ 2023-12-11 ] | ||||||||||||||||||||||||||||||||||||||||
|
This was completed long ago. T bug is fixed, as described in comments. And the temporary work-around was removed as part of commit 1e0f09cacbb05eec95078e10df1ea610736b9c1a. |