[MDEV-8177] Remove Lex_input_stream::m_cpp_buf Created: 2015-05-18 Updated: 2021-05-11 |
|
| Status: | Open |
| Project: | MariaDB Server |
| Component/s: | Parser |
| Fix Version/s: | None |
| Type: | Task | Priority: | Minor |
| Reporter: | Alexander Barkov | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | performance, refactoring | ||
| Description |
|
We can try to get rid of all m_cpp_xxx members in Lex_input_stream.
Notice, the column name does not include the comment part. The current code copies the original query into m_cpp_buf (removing comments on the way), so the second copy of the original query is always created. This affects performance negatively. Moreover, in most cases queries do not have comments at all. Related pieces of the code:
|