[MDEV-8068] 64 bit Windows integer casts warnings Created: 2015-04-28 Updated: 2021-09-04 Resolved: 2018-01-10 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Compiling |
| Affects Version/s: | 5.5, 10.0, 10.1 |
| Fix Version/s: | 10.2.10 |
| Type: | Bug | Priority: | Major |
| Reporter: | Vicențiu Ciorbaru | Assignee: | Vladislav Vaintroub |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | ulong | ||
| Issue Links: |
|
||||||||
| Sprint: | 10.1.30, 5.5.59 | ||||||||
| Description |
|
Due to platform compiler differences, we have a lot of warnings throughout MariaDB's codebase when compiled on Windows 64Bit. We should aim to replace all variables that can represent size, array indexes, array sizes, memory sizes, etc. with size_t, in order to maintain portability across platforms.
|
| Comments |
| Comment by Elena Stepanova [ 2017-11-05 ] |
|
I think wlad has fixed a lot in the area, but I'm not sure about which versions he fixed and which not. |
| Comment by Sergei Golubchik [ 2018-01-10 ] |
|
wlad, can it be closed? Or are there more warnings to fix? |
| Comment by Vladislav Vaintroub [ 2018-01-10 ] |
|
I would not invest into 5.5- 10.1, since it requires fairly large changes. I'd rather see -Wconversion fixed on gcc in newer versions. |
| Comment by Vladislav Vaintroub [ 2018-01-10 ] |
|
Too much effort required for downlevel versions. in 10.2+, most warnings are fixed. |