Spider-VP Spiral Patches (MDEV-14509)

[MDEV-7735] Spiral patch 039_mariadb-10.0.15.child_partition_pruning.diff Created: 2015-03-11  Updated: 2022-06-16

Status: Stalled
Project: MariaDB Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Technical task Priority: Major
Reporter: Sergey Vojtovich Assignee: Michael Widenius
Resolution: Unresolved Votes: 0
Labels: spiral_p16

Attachments: File 039_mariadb-10.0.15.child_partition_pruning.diff    
Issue Links:
Blocks
blocks MDEV-7795 Merge vertical partitioning storage e... Stalled

 Comments   
Comment by Sergei Petrunia [ 2015-10-13 ]

The patch includes

   if (!pprune_cond)
   {
     mark_all_partitions_as_used(part_info);
-    DBUG_RETURN(FALSE);
+    retval= base_table->file->prune_partitions_for_child(thd, pprune_cond);
+    DBUG_RETURN(retval);
   }

Which doesnt seem to make sense: it does not make any sensse to call prune_partitions_for_child(thd, NULL).

Comment by Sergei Petrunia [ 2015-10-13 ]

Looks weird. Why would one want to call prune_partitions() for individual partitions?

Comment by Jacob Mathew (Inactive) [ 2017-06-19 ]

The only data node storage engine, i.e. the only storage engine that actually stores data, that needs prune_partitions_for_child() to be called is MyISAM for Merge tables. However, support for this functionality has not yet been added to MyISAM Merge. Therefore the data node storage engines will always execute

virtual bool handler::prune_partitions_for_child(THD *thd, Item *pprune_cond) { return FALSE; }

That is why this code looks weird right now. It looked weird to me too, until Kentoku explained it. In the meantime, this functionality is only supported by the Vertical Partioning Storage Engine for its vertical partitions. Until Kentoku merges that engine into MariaDB, refer to the tar at http://spiderformysql.com/downloads/spider-3.3/patch_mariadb-10.2.0.tgz to see the details of how that engine uses prune_partitions_for_child().

Comment by Jacob Mathew (Inactive) [ 2017-09-01 ]

Commit 9c8db1d integrates Spiral patches 039 and 047, for adding child partition pruning support to the Vertical Partition Engine, in branch bb-10.2-spider-extra-jacob.

Comment by Kentoku Shiba (Inactive) [ 2019-04-04 ]

I pushed this the followings. Please review it.
3a6dbfd

Generated at Thu Feb 08 07:21:52 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.