[MDEV-7722] Spiral patch 024_mariadb-10.0.15.log_result_errors.diff Created: 2015-03-11  Updated: 2017-08-02  Resolved: 2017-08-02

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Sergey Vojtovich Assignee: Michael Widenius
Resolution: Duplicate Votes: 0
Labels: spiral_p12

Attachments: File 024_mariadb-10.0.15.log_result_errors.diff    
Issue Links:
Duplicate
duplicates MDEV-7389 Request: log warnings into SQL_ERROR_LOG Closed
Epic Link: Spiral patches

 Description   

Option to log errors in the results sent to the MySQL client



 Comments   
Comment by Jacob Mathew (Inactive) [ 2017-06-02 ]

The task is completed in the bb-10.2-spider-jacob branch, waiting to be merged into the 10.2-spider branch after Monty has finished his Spider patch integration work.

Comment by Michael Widenius [ 2017-07-18 ]

Pushed into bb-10.3-monty. Will be pushed to 10.3 soon with the rest of the patches in this tree.

Here is the commit message:

MDEV-7722 Add new variable log_result_errors

  • MDEV-772 originally named as spider patch
    024_mariadb-10.2.0.log_result_errors.diff
  • log_result_errors allows one to log warnings and errors to the error log
  • This patch has the following differences compared to the original patch:
  • Fixed output to be compatible with rest of error log
  • Simplified code (removed duplicate code)
  • Added mutex protection
  • Added test case
  • Only allow levels 0-3 (level 4, printing of information for every
    result is not that useful and would fill up error log quickly).
Comment by Michael Widenius [ 2017-08-02 ]

After talking with Sergei, we concluded that we will not take this patch as we have in 10.1 the sql_error_log plugin
that already handles some of the cases of the log_result_error variable. We plan to extend this to also log warnings and notes.

See https://mariadb.com/kb/en/mariadb/sql_error_log-plugin/

Comment by Michael Widenius [ 2017-08-02 ]

MDEV-7389 will replace this task

Comment by Michael Widenius [ 2017-08-02 ]

Will not apply

Generated at Thu Feb 08 07:21:47 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.