[MDEV-7700] Spiral patch 002_mariadb-10.0.15.spider.diff Created: 2015-03-11 Updated: 2017-12-03 Resolved: 2016-12-12 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - Spider |
| Fix Version/s: | N/A |
| Type: | Task | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Kentoku Shiba (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | spiral_p02 | ||
| Attachments: |
|
| Epic Link: | Spiral patches |
| Description |
|
Description: |
| Comments |
| Comment by Michael Widenius [ 2016-11-21 ] |
|
diff -Narup ./001_mariadb-10.1.8-partition_cond_push/sql/ha_partition.cc ./002_mariadb-10.1.8-spider/sql/ha_partition.cc +/* I don't think it will work removing the usage of p_elem->connect_string This is because each partition may have a different connect string. Here is an example from fedarated_partion.test: eval create table t1 (s1 int primary key) engine=federated The above works in mariadb 10.2 but not in your spider tree. From this patch I will, for now, only take the code related to HA_EXTRA_WRITE_CAN_REPLACE — ./001_mariadb-10.1.8-partition_cond_push/sql/sql_plugin.cc 2015-10-13 23:49:10.188129839 +0900
As my_free is safe to call with NULL, the above is not needed diff -Narup ./001_mariadb-10.1.8-partition_cond_push/sql/sql_priv.h ./002_mariadb-10.1.8-spider/sql/sql_priv.h +#define PLUGIN_VAR_CAN_MEMALLOC The above is not needed, as all code that is testing this is doing: #if defined(MARIADB_BASE_VERSION) && MYSQL_VERSION_ID >= 100000 Which is always true in MariaDB 10.x |
| Comment by Michael Widenius [ 2016-11-21 ] |
|
Check my comments and/or email |
| Comment by Michael Widenius [ 2016-12-12 ] |
|
Discussed with Kentoku |