[MDEV-7542] DOUBLE(0,0) is now converted to DOUBLE - unexpected behavior Created: 2015-02-05 Updated: 2017-02-06 Resolved: 2016-07-09 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Parser |
| Affects Version/s: | 10.1.2 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Minor |
| Reporter: | Elena Stepanova | Assignee: | Sergei Golubchik |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
As discussed, the following revision has an unexpected side-effect
Before this change, column definition c DOUBLE(0,0) was rejected with ER_TOO_BIG_DISPLAYWIDTH:
Since this revision, it is accepted and the column is stored as DOUBLE:
I don't see anything bad in it, but since it's unexpected it is suspicious. |
| Comments |
| Comment by Elena Stepanova [ 2015-02-05 ] |
|
Some storage_engine tests (col_opt_not_null col_opt_null col_opt_unsigned col_opt_zerofill type_float) have been adjusted to accept the new behavior. If you decide to change it, the tests should be updated as well. The easy way to do it is to run MTR as |
| Comment by Sergei Golubchik [ 2016-07-09 ] |
|
I think new behavior is better. ER_TOO_BIG_DISPLAYWIDTH looks weird. Something like "incorrect width" could've been even better, but is probably not worth a new error message just for that. |