[MDEV-7504] tons of -Woverloaded-virtual warnings in CONNECT Created: 2015-01-26  Updated: 2015-01-28  Resolved: 2015-01-28

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Connect
Affects Version/s: 10.0.16
Fix Version/s: 10.0.17

Type: Bug Priority: Major
Reporter: Sergei Golubchik Assignee: Olivier Bertrand
Resolution: Fixed Votes: 0
Labels: None

Attachments: HTML File typescript    

 Description   

In 10.0.16 after the 5.5 merge we've got -Woverloaded-virtual warning mode enabled. Connect engine produces lots of warnings of this kind.

These warnings seem serious, better to have them fixed.

 Comments   
Comment by Olivier Bertrand [ 2015-01-26 ]

Sergei, could you send me a compilation log showing those warnings and explain to me what do they mean?
Thanks.

Comment by Sergei Golubchik [ 2015-01-26 ]

Sure, I've attached the log. The warning itself is pretty clear, but here's an explanation, just in case. Quoting gcc manual:

‘-Woverloaded-virtual (C++ and Objective-C++ only)’
 
 
 
     Warn when a function declaration hides virtual functions from a
 
     base class.  For example, in:
 
 
 
          struct A {
 
            virtual void f();
 
          };
 
 
 
          struct B: public A {
 
            void f(int);
 
          };
 
 
 
     the ‘A’ class version of ‘f’ is hidden in ‘B’, and code like:
 
 
 
          B* b;
 
          b->f();
 
 
 
     fails to compile.

Generated at Thu Feb 08 07:20:05 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.