CentOS, Fedora, RHEL

For Windows users we should add STDCALL macros to

include/sql_common.h:
unsigned long STDCALL cli_safe_read(MYSQL *mysql);

sql-common/client.c:
ulong STDCALL
cli_safe_read(MYSQL *mysql)

I edited ticket, this issue affects all versions of MariaDB.

Also I attach a small diff, which could be applied on all versions.

patch to fix issue 7419

Anybody read this issue?

I can send patch, it's small and won't break anything...

Nobody read it yet, because there were no 5.5 releases between the date this issue was created and today. But somebody (probably, I) will certainly read it before the next 5.5 release.

I set 5.5 release, but this issue is for all versions.

cli_safe_read() is the only way to read raw MySQL answer at client side, and that's why should be exported.

I see. But MariaDB client API was never supposed to provide access to the raw network packets. It only had high-level functions.

I kind of agree that it could be useful to provide a lower-level API, that allows to manipulate raw packets. But I don't really want to do it in an ad-hoc manner by exporting internal functions on request.

So, what low-level functionality one may need? Reading a packet, like cli_safe_read(), sure. Writing a packet? What one needs to parse a data packet? net_field_length() like in that Facebook's HipHop link? Anything else?

You are right, it is not good idea to export internal functions, but there is no other way to do some things.

I can speak only about my piece of software — C++ library for getting replication log, and it requires two functions: cli_safe_read() and net_field_length().
It is easy to copy/paste net_field_length(), and I did it already, but no way to make any replacement for cli_safe_read().

But it is good idea to add both functions — for reading and writing packets to socket.

I know, this looks to be dirty hack, but almost all export functions in that list are hacks.

okay. I'll export cli_safe_read() and net_field_length(), but rename them to have mysql_ prefix.
mysql_net_read_packet() and mysql_net_field_length().

Thanks!

It is good idea to use prefixes, but how can I detect which function I have?

Are there any defines to check whether I have to user function with prefix or not?

You can do, say

#if MYSQL_VERSION_ID > 50541 && defined(MARIADB_BASE_VERSION)

/* MariaDB-5.5.42 or later, with low-level mysql_net_ API */

#else

#define mysql_net_read_packet cli_safe_read

#define mysql_net_field_length net_field_length

#endif

One more question, have you merged thinge to 10.0.x and 10.1.x branches?

No, I have not. But, of course, I will. This change will be in the next 10.0 release. And in the next 10.1 that follows in the next 10.0 release. That is, in 10.0.17 and 10.1.4