[MDEV-7225] sql bench test-transactions does not run on tokudb Created: 2014-11-27  Updated: 2016-07-13  Resolved: 2016-07-13

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - TokuDB, Tests
Affects Version/s: 10.0.15, 10.1.14
Fix Version/s: 10.1.16

Type: Bug Priority: Major
Reporter: Rich Prohaska Assignee: Sergei Golubchik
Resolution: Fixed Votes: 1
Labels: contribution, foundation
Environment:

linux ubuntu 14


Sprint: 1.0.2

 Description   

./test-transactions --create-options=engine=tokudb --socket=/tmp/rfp.sock
Testing server 'MySQL 10.0.15 MariaDB debug' at 2014-11-27  7:43:58
 
Test skipped because the database doesn't support transactions

Needs this fix:
https://github.com/Tokutek/mariadb-10.0/commit/4dc93065ff41d57c71396ff55a32598d42e1ac9d



 Comments   
Comment by Daniel Black [ 2016-06-21 ]

the fix link is now broken. Cannot easily see this in the mariadb-server repo of the same commit id either.

Comment by Sergei Golubchik [ 2016-06-24 ]

even without the link, I suppose, the patch was to edit sql-bench/server-cfg that sets various flags based on the engine name, and add there something like

  if (defined($main::opt_create_options) &&
      $main::opt_create_options =~ /engine=tokudb/i)
  {
    $self->{'transactions'}	= 1;	# Transactions enabled
  }

Comment by Rich Prohaska [ 2016-06-25 ]

Yes, that is the patch and this pull request works on 10.1: https://github.com/MariaDB/server/pull/192

Comment by Sergey Vojtovich [ 2016-06-28 ]

Updated fix version to 10.1 since PR is against 10.1.

Comment by Rich Prohaska [ 2016-06-28 ]

I just emailed a signed mariadb contributor agreement.

Comment by Sergey Vojtovich [ 2016-06-28 ]

MCA received, thanks!

Generated at Thu Feb 08 07:17:57 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.