[MDEV-7223] Iterator for LF_HASH Created: 2014-11-26 Updated: 2014-12-28 Resolved: 2014-12-28 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Locking |
| Fix Version/s: | 10.1.3 |
| Type: | Task | Priority: | Critical |
| Reporter: | Sergei Golubchik | Assignee: | Sergey Vojtovich |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
to be able to use LF_HASH in table definition cache and MDL cache, we need an iterator for LF_HASH |
| Comments |
| Comment by Sergei Golubchik [ 2014-11-28 ] |
|
Pushed into bb-lf-iterator branch. |
| Comment by Sergey Vojtovich [ 2014-11-28 ] |
|
API as such is alright. I just hope this extra if won't be that expensive. |
| Comment by Sergei Golubchik [ 2014-11-28 ] |
|
Thanks. I hope not, it's inside unlikely() so in the normal use case it should be cheap. And I've removed one if in the previous changeset, which should compensate to an extent. Old if was actually worse — it was comparing volatile shared values and under high concurrency the expression could often return different results. New if expression uses only local variables and is false almost always. |
| Comment by Sergei Golubchik [ 2014-12-03 ] |
|
svoj, please push it into 10.1 when and as you see fit. It's all your. |