[MDEV-7062] parser refactoring: don't store field properties in LEX Created: 2014-11-10  Updated: 2014-12-04  Resolved: 2014-12-04

Status: Closed
Project: MariaDB Server
Component/s: Parser
Fix Version/s: 10.1.2

Type: Task Priority: Major
Reporter: Sergei Golubchik Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: None


 Description   

Currently when parsing a field definition all field properties are stored in LEX. LEX is kind of "everything and a kitchen sink" storage, it's way too large and lots of data that is there shouldn't be.

This task is about removing field properties (that are used when parsing field definitions) from LEX and putting them into Create_field class directly

 Comments   
Comment by Sergei Golubchik [ 2014-11-10 ]

http://lists.askmonty.org/pipermail/commits/2014-November/006908.html

From: serg@mariadb.org
 
To: commits@mariadb.org
 
Subject: [Commits] 2c904b9: parser cleanup: don't store field properties
 
         in LEX, use Create_field directly
 
Date: Mon, 10 Nov 2014 10:26:48 +0100

Also the commit is in bb-10.1-serg tree. The idea is — to split Create_field::init in assignment and check phases. And do assignments directly in sql_yacc.yy, so Create_field::check (renamed ::init) will only do the check.

Generated at Thu Feb 08 07:16:40 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.