FreeBSD bobthebuilder 10.0-RELEASE-p7 FreeBSD 10.0-RELEASE-p7 #0: Tue Jul 8 06:37:44 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC

Patches that enable build on FreeBSD 10.0 clang 3.3

And a patch for
storage/connect/array.cpp:132:26: �error: cast from pointer to smaller type 'int' loses information�

This function was wrongly defined but fortunately never used. However, it was fixed (just in case...) as:

virtual int   GetNextPos(void) {return GetPos() + 1;}

Great!
I attached a patch for connect_array as well which is unrelated to the filamap compile issue I encountered. Would you want me to open another bug for this or can you check this as well?

Sorry, I closed this before reading your last comments. About your patches:

in filamap.h:
Your patches on InitDelete are incorrect. These are virtual functions that must have the same signature as the base class one.

in filamap.cpp:
If there is a problem when the function is still defined as InitDelete(PGLOBAL g, int fpos, int spos) I suggest the following patches:

   Fpos = Memory + (uintptr_t)fpos;

   Mempos = Memory + (uintptr_t)spos;

and the same casting in MPXFAM::InitDelete. This is not necessary with the MS or GCC compilers. Let me know whether it is with clang.

In array.cpp:
This patch is also incorrect and would make the program fail or even crash!
Indeed, the parmp->Value variable is a void pointer but to avoid having to allocate an integer and make it point on it I choosed to directly put the integer value in it. This is tricky and not really correct but was done to save memory allocation.
It works with MS and GCC that flag the casting (int)parmp->Value as a warning. With clang, the problem is to extract an integer from a pointer. Perhaps (int)(uintptr_t)parmp->Value would work? Let me know whether you have a solution for this. If not, I shall have to redesign the whole thing (perhaps using another stucture with a union in it)

Reopened until you tell me whether my last suggestions work with clang

Thanks for your guidance Olivier Please find revised patches attached, Mariadb-10.0.14 builds on FreeBSD 10.0 with these patches.

I applied the new patches successfully on Windows. However, on Linux the GCC compiling failed saying that uintptr_t was undeclared.
Therefore I added:

#include <stdint.h>         // for uintprt_h

into the Unix declare section.
Is this ok with clang on FreeBSD?

Hi Olivier,
This is OK without adding an include for stdint.h anywhere in the storage/connect/ code
Built, packaged and deployed the server without a problem using the attached patches (sorry for the DOS CRLF)

This should fix all compiler issues. However, to do it in a cleaner way, I did not exactly apply the above patches:

In the InitDelete functions I changed the cast from uintptr_t to ptrdiff_t, which seems more appropriate and does not require including stdint.h.

About the array making, I have added an union in the PARM structure:

typedef struct _parm {

  union {

    void *Value;

    int   Intval;

    }; // end union

  short Type, Domain;

  PPARM Next;

  } PARM;

This makes possible to suppress all the funny casting that were done when creating the structure (in TXTFAM::AddListValue) and retrieving the integer value from it (in MakeValueArray)