[MDEV-6720] enable connection log in mysqltest by default Created: 2014-09-10  Updated: 2016-07-21  Resolved: 2016-03-31

Status: Closed
Project: MariaDB Server
Component/s: Tests
Fix Version/s: 10.2.0

Type: Task Priority: Minor
Reporter: Sergei Golubchik Assignee: Sergey Vojtovich
Resolution: Fixed Votes: 0
Labels: None

Sprint: 10.2.0-6, 10.2.0-7, 10.2.0-8, 10.2.0-9, 10.2.0-10

 Description   

mysqltest has commands

--enable_connect_log
--disable_connect_log

the default behavior is disable, we should make it enable by default.



 Comments   
Comment by Sergei Golubchik [ 2015-11-17 ]

and then we can remove few *.include files that do just that — switch connection with a message

Comment by Sergey Vojtovich [ 2016-03-25 ]

serg, please review patch for this task. It is 95% complete, available in bb-10.2-MDEV-6720. I expect there're still tests to be stabilized (to be discovered by bb). I'll commit further changes on top of it and squash before pushing.

Comment by Sergei Golubchik [ 2016-03-30 ]

You seem to be getting tasks that remove lots of code

This one: 64 insertions, 3414 deletions (not counting result files).

Comment by Sergei Golubchik [ 2016-03-30 ]

Ok to push, thanks!
One comment only: the change in rpl_begin_commit_rollback.test looks like a genuine bug in the test. Please, fix it, in a separate commit.

diff --git a/mysql-test/suite/rpl/t/rpl_begin_commit_rollback.test b/mysql-test/suite/rpl/t/rpl_begin_commit_rollback.test
--- a/mysql-test/suite/rpl/t/rpl_begin_commit_rollback.test
+++ b/mysql-test/suite/rpl/t/rpl_begin_commit_rollback.test
@@ -133,8 +129,7 @@ source include/wait_for_slave_sql_to_start.inc;
 --echo # SAVEPOINT and ROLLBACK TO have the same problem in BUG#43263
 --echo # This was reported by BUG#50407
 connection master;
-echo [on master]
-SET SESSION AUTOCOMMIT=0;
+echo SET SESSION AUTOCOMMIT=0;
 let $binlog_start=query_get_value(SHOW MASTER STATUS, Position, 1);
 
 BEGIN;

Comment by Sergey Vojtovich [ 2016-03-30 ]

Compared to previous tasks that removed lots of code, this one was disaster.

I also came across the same line in rpl_begin_commit_rollback.test, but I couldn't immediately find out if this test was actually supposed to set autocommit or not. I'll double check it.

Thanks!

Generated at Thu Feb 08 07:14:05 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.