[MDEV-6693] Atomic operations with explicit memory barrier Created: 2014-09-04 Updated: 2014-10-21 Resolved: 2014-10-14 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | OTHER |
| Fix Version/s: | 10.1.1 |
| Type: | Task | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Sergey Vojtovich |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Description |
|
Currently atomic operations create full memory barrier. This ensures correct program behavior. However weaker memory barriers have lower performance impact and there are many cases when weaker memory barrier is sufficient. The idea of this task is to adopt C11 atomic API to some extent, so it is possible to specify memory barriers for atomic operations. C11 atomic operations as such seem to be unavailable in many environments. E.g. they appeared only in gcc-4.9. MSVC doesn't seem to support them, same for Solaris Studio. It is proposed to use gcc atomic builtins whenever they're available, otherwise fall back to atomic operations with implicit full memory barrier. |
| Comments |
| Comment by Sergey Vojtovich [ 2014-09-04 ] | |||||||||
|
Sergei, please review patch for this task. It is committed against 10.0, I will leave up to you to decide into which version it is supposed to be pushed to. | |||||||||
| Comment by Sergei Golubchik [ 2014-10-14 ] | |||||||||
|
ok to push (in 10.1) | |||||||||
| Comment by Sergey Vojtovich [ 2014-10-14 ] | |||||||||
|
Pushed to 10.1.1:
|