[MDEV-6412] Code style need to be the same Created: 2014-07-01 Updated: 2014-10-14 Resolved: 2014-10-14 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | OTHER |
| Affects Version/s: | 10.1.0 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Trivial |
| Reporter: | zhifeng hu | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Environment: |
linux |
||
| Description |
|
The source code of the mariadb had many bad code style mesh. mixed with Space indent and tab indent. and space before or after equal sign not all them same
you always confused with this bad code style. can we tidy them ? or do we have andy strict code style rules? |
| Comments |
| Comment by zhifeng hu [ 2014-07-01 ] | |||
|
And the other bad smell.
some function call have space after comma, but other do not have. | |||
| Comment by Sergey Vojtovich [ 2014-07-02 ] | |||
|
MySQL/MariaDB always had coding style violations for various reasons. As a rule of thumb it was agreed to enforce coding style rules only for newly written and modified code. One of good reasons was to avoid loss of "direct" RCS history. For the very same reason I'd vote to follow that rule and avoid separate coding style fixes. | |||
| Comment by zhifeng hu [ 2014-07-03 ] | |||
|
I thought there should be strict rules, force coding by rules or law. Code must clean and clear, not just ok for running. Running is simple, continue improve and maintain code is hard. Can we make life easier? | |||
| Comment by zhifeng hu [ 2014-09-05 ] | |||
|
Now the official MySQL has it's code style guide. a big step forward. http://dev.mysql.com/doc/internals/en/assignment.html | |||
| Comment by Elena Stepanova [ 2014-10-14 ] | |||
|
The first link is for NDB coding guidelines, and even there it says clearly that
and
I suppose that code reviews take care of the completely new code. Based on the quotes and the earlier comment by svoj, closing for now as "Won't fix". |