[MDEV-6410] Cross-compile fixes Created: 2014-06-30  Updated: 2014-09-07  Resolved: 2014-07-08

Status: Closed
Project: MariaDB Server
Component/s: None
Fix Version/s: 10.0.13

Type: Task Priority: Major
Reporter: Colin Charles Assignee: Sergei Golubchik
Resolution: Fixed Votes: 1
Labels: contribution

Issue Links:
Relates
relates to MDEV-6562 MDEV-6410 breaks WITHOUT_SERVER build Closed
relates to MDEV-6579 IMPORT_EXECUTABLES feature broken by ... Closed

 Description   

James Le Cuirot (chewi@aura-online.co.uk) wants to provide the following code under the MCA

The bug in question: http://bugs.mysql.com/bug.php?id=61340

The merge request: https://code.launchpad.net/~chewi/maria/mysql-fix-bug61340/+merge/217351

The diff: http://bazaar.launchpad.net/~chewi/maria/mysql-fix-bug61340/revision/4165

The post to maria-developers: https://lists.launchpad.net/maria-developers/msg07383.html

 Comments   
Comment by James Le Cuirot [ 2014-06-30 ]

Thanks for looking at this. I have subscribed here so can respond to any feedback here.

Comment by Brian Evans [ 2014-08-11 ]

This is broken when WITHOUT_SERVER is enabled.
gen_lex_hash is not built and the cmake command errors out since it is part of the sql directory.

Comment by James Le Cuirot [ 2014-08-11 ]

Apologies if this was the cause though I'm not entirely sure that it is. I see that you are a Gentoo developer and I actually made this change primarily for Gentoo's benefit. See the somewhat-related Gentoo bug #503216. I'll try to find you on IRC.

Comment by Brad Smith [ 2014-08-12 ]

Trying to update our OpenBSD port / package I noticed the same error Brian mentioned..

-- Check size of unsigned long long
 
-- Check size of unsigned long long - done
 
CMake Error at CMakeLists.txt:472 (EXPORT):
 
  export given target "gen_lex_hash" which is not built by this project.

which is this section..

IF(NOT CMAKE_CROSSCOMPILING)
 
  SET(EXPORTED comp_err comp_sql factorial gen_lex_hash)
 
  # minimal target to build only binaries for export
 
  ADD_CUSTOM_TARGET(import_executables DEPENDS ${EXPORTED})
 
  EXPORT(TARGETS ${EXPORTED} FILE ${CMAKE_BINARY_DIR}/import_executables.cmake)
 
ENDIF()

Comment by Brian Evans [ 2014-08-12 ]

Patch posted in MDEV-6562

Generated at Thu Feb 08 07:11:41 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.