[MDEV-6339] deprecate log-slow-admin-statements, Better user experience with slow log filters Created: 2014-06-13  Updated: 2023-08-07  Resolved: 2023-01-22

Status: Closed
Project: MariaDB Server
Component/s: Server
Fix Version/s: 11.0.1

Type: Task Priority: Major
Reporter: VAROQUI Stephane Assignee: Daniel Black
Resolution: Fixed Votes: 3
Labels: None


 Description   

Hidden server parameter --log-slow-admin-statements

  • is not a server variable
  • is confusing with variable log_slow_filter=admin

The task would deprecate parameter log-slow-admin-statements, setting is default compile value to yes.

changing log_slow_filter to same usage as optimizer_switch using boolean mode

Reading word filter one expect that admin=yes or just admin means that the server filter admin statements.
What append today is the opposite and that's confusing in itself !

To be consistent we can rename log_slow_filter to log_slow_switch where admin=yes would mean that we don't filter admin statements.

The default would become log_slow_switch="admin=no" to get same content inside slow query log as today



 Comments   
Comment by Daniel Black [ 2022-12-04 ]

Start with https://github.com/MariaDB/server/pull/2357 deprecation.

Not sure I like the optimizer switch of putting a lot of variables into one variable. I've found it horridly hard to manipulate.

I think filter can be read as inclusive or exclusive. Other filter uses seem to be inclusive.

Generated at Thu Feb 08 07:11:09 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.