[MDEV-6313] mysqld --log-bin=no-such-dir/master crashes during server initialization Created: 2014-06-06  Updated: 2014-07-23  Resolved: 2014-07-23

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 5.5.38, 10.0.11
Fix Version/s: 5.5.39, 10.0.13

Type: Bug Priority: Major
Reporter: Sergey Vojtovich Assignee: Sergey Vojtovich
Resolution: Fixed Votes: 0
Labels: None


 Description    

#0  0x00007f1598e5df0c in __pthread_kill (threadid=<optimized out>, signo=11) at ../nptl/sysdeps/unix/sysv/linux/pthread_kill.c:62
 
62	../nptl/sysdeps/unix/sysv/linux/pthread_kill.c: No such file or directory.
 
#0  0x00007f1598e5df0c in __pthread_kill (threadid=<optimized out>, signo=11) at ../nptl/sysdeps/unix/sysv/linux/pthread_kill.c:62
 
#1  0x0000000000cde211 in my_write_core (sig=11) at /home/svoj/devel/maria/5.5/mysys/stacktrace.c:457
 
#2  0x00000000007c3c70 in handle_fatal_signal (sig=11) at /home/svoj/devel/maria/5.5/sql/signal_handler.cc:262
 
#3  <signal handler called>
 
#4  0x000000000088c6e2 in MYSQL_LOG::generate_new_name (this=0x1568c88 <mysql_bin_log+8>, new_name=0x1568d38 <mysql_bin_log+184> "no-such-dir/master.1", log_name=0x7f1596bae420 "no-such-dir/master") at /home/svoj/devel/maria/5.5/sql/log.cc:2526
 
#5  0x000000000088bd75 in MYSQL_LOG::init_and_set_log_file_name (this=0x1568c88 <mysql_bin_log+8>, log_name=0x7f1596bae420 "no-such-dir/master", new_name=0x0, log_type_arg=LOG_BIN, io_cache_type_arg=WRITE_CACHE) at /home/svoj/devel/maria/5.5/sql/log.cc:2324
 
#6  0x000000000088e70c in MYSQL_BIN_LOG::open (this=0x1568c80 <mysql_bin_log>, log_name=0x7f1596bae420 "no-such-dir/master", log_type_arg=LOG_BIN, new_name=0x0, io_cache_type_arg=WRITE_CACHE, no_auto_events_arg=false, max_size_arg=1073741824, null_created_arg=false, need_mutex=true) at /home/svoj/devel/maria/5.5/sql/log.cc:3044
 
#7  0x0000000000557059 in init_server_components () at /home/svoj/devel/maria/5.5/sql/mysqld.cc:4489
 
#8  0x0000000000557aae in mysqld_main (argc=82, argv=0x7f1597813bb0) at /home/svoj/devel/maria/5.5/sql/mysqld.cc:4932
 
#9  0x000000000054fdfd in main (argc=7, argv=0x7fff7756b638) at /home/svoj/devel/maria/5.5/sql/main.cc:25

Got this crash while creating a test case.
AAA.test: empty (or SELECT 1)
AAA.opt: --log-bin=no-such-dir/master

I guess the problem is likely ER() macro calling current_thd which is most probably not available during server initialization. Probably it should be switched to something like ER_DEFAULT()

 Comments   
Comment by Sergey Vojtovich [ 2014-06-24 ]

Sergei, please review fix for this bug.

Comment by Sergei Golubchik [ 2014-07-23 ]

ok to push!

Comment by Sergey Vojtovich [ 2014-07-23 ]

Pushed to 5.5.39:

revno: 4232
 
revision-id: svoj@mariadb.org-20140624074135-ufhdebpx0lj0d7y4
 
parent: svoj@mariadb.org-20140617090326-apdd9257mucpd2xq
 
committer: Sergey Vojtovich <svoj@mariadb.org>
 
branch nick: 5.5
 
timestamp: Tue 2014-06-24 11:41:35 +0400
 
message:
 
  MDEV-6313 - mysqld --log-bin=no-such-dir/master crashes during
 
              server initialization
 
  
  ER() macro was used during server initialization. It refers to
 
  current_thd, which is not available that early.
 
  
  Print error to error log in "lc-messages" locale.
 
  Avoid duplicate error message during server initialization.

Generated at Thu Feb 08 07:10:56 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.