[MDEV-6236] [PATCH] mysql_tzinfo_to_sql may produce invalid SQL Created: 2014-05-13  Updated: 2019-04-29  Resolved: 2015-06-05

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients
Affects Version/s: 5.5.37, 10.0.10
Fix Version/s: 5.5.44, 10.0.20, 10.1.6

Type: Bug Priority: Major
Reporter: Hartmut Holzgraefe Assignee: Sergey Vojtovich
Resolution: Fixed Votes: 0
Labels: upstream-fixed
Environment:

Linux


Attachments: HTML File patch    
Issue Links:
Relates
relates to MDEV-749 LP:780108 - Couldn't import zoneinfo ... Open
Sprint: 5.5.44

 Description   

/usr/share/zoneinfo may contain some files where a warning like

Local time zone must be set--see zic manual page

may be given instead of a time zone abbreviation for time_zone_transition_type.

This leads to output like:

  INSERT INTO time_zone (Use_leap_seconds) VALUES ('N');
  SET @time_zone_id= LAST_INSERT_ID();
  INSERT INTO time_zone_name (Name, Time_zone_id) VALUES ('Factory', @time_zone_id);
  INSERT INTO time_zone_transition_type (Time_zone_id, Transition_type_id, Offset, Is_DST, Abbreviation) VALUES
  (@time_zone_id, 0, 0, 0, 'Local time zone must be set--see zic manual page')
  ;

which will fail if sql_mode=STRICT_ALL_TABLES is set as the "Local time zone ..." string is much longer than the 8 characters reserved for "Abbreviation" in the time_zone_transition_type table

Suggestion: filter out these time zones completely and don't get INSERT statements for them at all as they contain no useful information anyway ...

See also http://bugs.mysql.com/bug.php?id=68861



 Comments   
Comment by Hartmut Holzgraefe [ 2014-05-13 ]

proposed patch to ignore invalid entries

Comment by Elena Stepanova [ 2015-06-02 ]

Fixed in MySQL 5.7.5

Comment by Sergey Vojtovich [ 2015-06-03 ]

serg, please review fix for this bug.

Generated at Thu Feb 08 07:10:22 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.