[MDEV-6069] Remove old logic for 3.23-to-higher upgrades from upgrade SQL scripts Created: 2014-04-11  Updated: 2015-11-04  Resolved: 2015-10-27

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Fix Version/s: 10.1.4

Type: Task Priority: Major
Reporter: Elena Stepanova Assignee: Nirbhay Choubey (Inactive)
Resolution: Fixed Votes: 0
Labels: upgrade

Issue Links:
Relates
relates to MDEV-6068 Upgrade removes all changes to 'mysql... Closed

 Description   

Scripts used for upgrade (e.g. mysql_system_tables_fix.sql) use ancient logic implemented for upgrades from very old versions, such as 3.23. It cannot stay there forever, the scripts grow complicated, and modification of them becomes error-prone. Since it is unrealistic to expect anyway, that live upgrade from such an old version would work, some clean-up is needed.

See MDEV-6068 for an example of such logic.

Also they can be simplified by using compound statements.



 Comments   
Comment by Nirbhay Choubey (Inactive) [ 2014-12-02 ]

http://lists.askmonty.org/pipermail/commits/2014-December/007123.html

Comment by Sergei Golubchik [ 2015-02-25 ]

I feel it's too radical. I still see questions about 5.1 every now and then.
Perhaps it's safer to remove only 3.23-5.0 code and keep upgrades from 5.1 and up?

Comment by Nirbhay Choubey (Inactive) [ 2015-02-25 ]

Sure, I will modify the patch and recommit.

Comment by Nirbhay Choubey (Inactive) [ 2015-03-14 ]

http://lists.askmonty.org/pipermail/commits/2015-March/007593.html

Comment by Sergei Golubchik [ 2015-03-14 ]

ok to push

Comment by Nirbhay Choubey (Inactive) [ 2015-03-17 ]

https://github.com/MariaDB/server/commit/5e6f12366abb02143ef57b6ff99285d81e3b3a36

Comment by Nirbhay Choubey (Inactive) [ 2015-03-17 ]

Addendum : http://lists.askmonty.org/pipermail/commits/2015-March/007621.html

Comment by Sergei Golubchik [ 2015-03-19 ]

ok to push

Comment by Michael Widenius [ 2015-10-27 ]

We should allow easy data migration between any MariaDB versions.

We now have people trying to move from MySQL 4.1 -> 10.1 and things fails as system tables are not converted.

Please revert this task

Comment by Nirbhay Choubey (Inactive) [ 2015-10-27 ]

monty I have opened https://mariadb.atlassian.net/browse/MDEV-9026 for this.

Generated at Thu Feb 08 07:09:08 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.