[#MDEV-5789] race between rpl_parallel_change_thread_count and slave start upon server start without --skip-slave-start

[MDEV-5789] race between rpl_parallel_change_thread_count and slave start upon server start without --skip-slave-start Created: 2014-03-04 Updated: 2014-03-07 Resolved: 2014-03-07
Status:	Closed
Project:	MariaDB Server
Component/s:	None
Affects Version/s:	10.0.8
Fix Version/s:	10.0.9

Type:

Bug

Priority:

Major

Reporter:

Kristian Nielsen

Assignee:

Kristian Nielsen

Resolution:

Fixed

Votes:

Labels:

None

Description

Reported on maria-developers@ by nanyi607rao:

Second is in rpl_parallel_change_thread_count()

I think it need add mysql_cond_broadcast(&pool->COND_rpl_thread_pool) after all new threads are ok, this is for
the case that skip_slave_start=OFF,then SQL thread would start automaticlly, it could wait forever in rpl_parallel_thread_pool::get_thread(), because SQL thread may reach this function before another thread reach the rpl_parallel_change_thread_count().

Comments

Comment by Kristian Nielsen [ 2014-03-07 ]

Pushed to 10.0

Generated at Thu Feb 08 07:07:04 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.

[MDEV-5789] race between rpl_parallel_change_thread_count and slave start upon server start without --skip-slave-start Created: 2014-03-04 Updated: 2014-03-07 Resolved: 2014-03-07