[MDEV-5780] create-big fails in 10.0 Created: 2014-03-03  Updated: 2014-03-10  Resolved: 2014-03-10

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 10.0.8
Fix Version/s: 10.0.10

Type: Bug Priority: Major
Reporter: Sergei Golubchik Assignee: Michael Widenius
Resolution: Fixed Votes: 0
Labels: None


 Description   

After CREATE OR REPLACE implementation the test create-big now fails.

Before CREATE OR REPLACE, a create .... select that tried to create an existing table, failed in mysql_execute_command():

      res= open_and_lock_tables(thd, lex->query_tables, TRUE, 0);
 
      if (res)
 
      {
 
        /* Got error or warning. Set res to 1 if error */
 
        if (!(res= thd->is_error()))
 
          my_ok(thd);
 
      }
 
      else
 
      {
 
        /* The table already exists */
 
        if (create_table->table)
 
        {
 
          if (create_info.options & HA_LEX_CREATE_IF_NOT_EXISTS)
 
          {
 
            push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_NOTE,
 
                                ER_TABLE_EXISTS_ERROR,
 
                                ER(ER_TABLE_EXISTS_ERROR),
 
                                create_info.alias);
 
            my_ok(thd);
 
          }
 
          else
 
          {
 
            my_error(ER_TABLE_EXISTS_ERROR, MYF(0), create_info.alias);
 
            res= 1;
 
          }
 
          goto end_with_restore_list;
 
        }

Now this if (create_table->table block is removed, so the failure happens much later. As a result, the test fails.

 Comments   
Comment by Michael Widenius [ 2014-03-10 ]

The test failed with:
+Warning 1639 debug sync point wait timed out

The issue was that create...trigger part of the test suite used a debug_sync point that before was never triggered (in other words, wrong meaningless test).
Now the debug sync point is triggered and the test case could not handled that.

I fixed this by adding a wait and go for debug the debug syncpoint in the test.

Comment by Michael Widenius [ 2014-03-10 ]

This was a bug in the test case. Fixed in my tree and will be shortly pushed into the 10.0 tree.

Generated at Thu Feb 08 07:07:00 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.