[MDEV-5745] analyze MySQL fix for bug#12368495 Created: 2014-02-26 Updated: 2014-07-28 Resolved: 2014-07-28 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | None |
| Fix Version/s: | 5.5.39 |
| Type: | Task | Priority: | Major |
| Reporter: | Sergei Golubchik | Assignee: | Alexander Barkov |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | upstream | ||
| Description |
|
MySQL 5.5.36 has a fix for Bug#12368495 CRASH AND/OR VALGRIND ERRORS WITH REVERSE FUNCTION AND CHARSET CONVERTS As usual, there is no test case. The patch adds an assert to Item_func_reverse::val_str() (which, apparently, was the reason of a crash in the first place) and changes Item_func_trim::val_str() to check (and re-check, inside a trimming loop!) multi-byte characters of the prefix. It is very suspicious, though, that the patch fixes only Item_func_trim::val_str(), but not the completely identical Item_func_ltrim::val_str(). Analysis revealed that: |
| Comments |
| Comment by Sergei Golubchik [ 2014-07-26 ] |
|
ok to push |