[MDEV-5419] no audit events for warnings converted to errors in the strict mode Created: 2013-12-09  Updated: 2014-01-29  Resolved: 2014-01-23

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 5.5.34
Fix Version/s: 5.5.35

Type: Bug Priority: Major
Reporter: Sergei Golubchik Assignee: Alexey Botchkov
Resolution: Fixed Votes: 1
Labels: audit

Issue Links:
Relates
relates to MDEV-4846 SQL_ERROR_LOG plugin doesn't log erro... Closed

 Description   

When an warnings is converted into an error because of the strict sql_mode, this conversion happens inside THD::raise_condition. And my_message_sql is not called, so no audit events are generated for this error.

Possible fixes:

  • generate audit events from THD::raise_condition (then they won't be generated when thd == 0)
  • always invoke my_message_sql for every error
  • some other way to make sure that all error processing code is invoked for any error

 Comments   
Comment by Alexey Botchkov [ 2013-12-15 ]

Proposed fix:
http://lists.askmonty.org/pipermail/commits/2013-December/005777.html

Also fixes the mentioned MDEV-4846.

Comment by Daniel Bartholomew [ 2014-01-29 ]

http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4028

Comment by Daniel Bartholomew [ 2014-01-29 ]

http://bazaar.launchpad.net/~maria-captains/maria/5.5/revision/4027

Generated at Thu Feb 08 07:04:15 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.