[MDEV-5319] Request for merge of Oqgraph v3 functionality storage/oqgraph into 10.0 Created: 2013-11-20 Updated: 2013-12-16 Resolved: 2013-12-11 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | None |
| Fix Version/s: | 10.0.7 |
| Type: | Task | Priority: | Major |
| Reporter: | Andrew McDonnell | Assignee: | Sergey Vojtovich |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Description |
|
As discussed with Sergei Golubchik and Arjen Lentz Will attach tarballs of storage/oqgraph and mysql-test/suite/oqgraph directories from |
| Comments |
| Comment by Arjen Lentz [ 2013-11-21 ] |
|
May I suggest the merge is done by pulling from or otherwise merging from the lp branch that Andrew showed, rather than grabbing the tarball? |
| Comment by Andrew McDonnell [ 2013-11-21 ] |
|
bzr merge proposed through launchpad: https://code.launchpad.net/~andymc73/maria/10.0-oqgraph3-varchar/+merge/196081 |
| Comment by Sergey Vojtovich [ 2013-11-29 ] |
|
Arjen, Andrew, thanks for your request. We just reviewed oqgraph revisions and here is our plan:
Please let us know if you feel any of the above is terribly wrong. |
| Comment by Andrew McDonnell [ 2013-12-02 ] |
|
Hi Sergey, Arjen did mention previously it would be nice to get the development history, Although my personal opinion is might be cleaner to do a bzr merge, maybe the I know if this was git and I way merging, I would have cleaned up my history Arjen, is the above correct, or did you simply mean the merge linkages? As for Judy YMMV I havent tested behaviour widely across distributions, and I --Andrew |
| Comment by Sergey Vojtovich [ 2013-12-02 ] |
|
Andrew, bzr rebase will preserve revision history ad put all your revisions on top of 10.0. The bad thing is that it will also invalidate lp:~andymc73/oqgraph/10.0-oqgraph3-varchar for further merges. If you plan to use this tree for development, it is better to bzr merge, if not (which I believe is the case) bzr rebase is acceptable. Still, it is up to you to choose which way suits your needs best. As for Judy: if there is absolutely no way to avoid it's inclusion on certain platforms, we'll have to accept it. But for now it is not clear yet. |
| Comment by Sergey Vojtovich [ 2013-12-11 ] |
|
Pushed to 10.0.7, svoj@mariadb.org-20131211090621-1xvoeglpemhtqwry |
| Comment by Arjen Lentz [ 2013-12-12 ] |
|
Awesome Sergey, thanks for all that work! Let's see how the MariaDB build farm deals with all this, and then look at what it might bring up. |
| Comment by Sergey Vojtovich [ 2013-12-12 ] |
|
Thanks Arjen! MariaDB build farm is not capable to deal with it yet due to lack of judy on most platforms. Watch |