[MDEV-4446] Test rpl.rpl_gtid_startpos doesn't work with binlog checksums Created: 2013-04-27  Updated: 2013-05-27  Resolved: 2013-04-29

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 10.0.2
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Pavel Ivanov Assignee: Kristian Nielsen
Resolution: Fixed Votes: 0
Labels: None


 Description   

I'm using 10.0.2 tarball, running simple "cmake ." and "make". After that simple "./mtr rpl.rpl_gtid_startpos" works, but "./mtr rpl.rpl_gtid_startpos -mysqld=-binlog-checksum=CRC32" times out after 900 seconds.
Quick look at the test doesn't reveal a hard dependency on particular binlog positions or something. So it could be that the actual problem is in mysql code.

 Comments   
Comment by Elena Stepanova [ 2013-04-27 ]

What are you running it on?
(isn't happening for me on Ubuntu 12.04 64-bit, so I am wondering if it's a race condition or system-related)

Comment by Pavel Ivanov [ 2013-04-27 ]

That's interesting. I have Ubuntu 12.04 64-bit too. Compilation was done with "gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)". I wonder what's different then.

Comment by Kristian Nielsen [ 2013-04-29 ]

Thanks for the report!

The problem was that the function Gtid_log_event::peek_is_commit_rollback() did not
correctly consider the extra 4 bytes of checksum in the event length, so it might miss a
COMMIT event (for non-transactional updates) and wrongly skip some event(s).

Currently we are not testing -mysqld=-binlog-checksum=CRC32, which is bad.
Especially since the MySQL 5.6 checksum design is quite bad and sure to cause
problems like this to be introduced again in the future.

I'll make sure that the test suite passes with binlog checksums and try to find a
Buildbot host to run tests with checksums enabled.

Comment by Kristian Nielsen [ 2013-04-29 ]

Pushed to 10.0-base.

revid: knielsen@knielsen-hq.org-20130429085748-xrrdwe59e9nzzdr0

Generated at Thu Feb 08 06:56:28 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.