[MDEV-4169] mysql-test-run doesn't strip expected warnings Created: 2013-02-12  Updated: 2013-02-14  Resolved: 2013-02-14

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 10.0.1, 5.5.29, 5.1.67, 5.2.14, 5.3.12
Fix Version/s: 10.0.2, 5.5.30, 5.1.73, 5.2.15, 5.3.13

Type: Bug Priority: Major
Reporter: Honza Horak Assignee: Elena Stepanova
Resolution: Fixed Votes: 0
Labels: None
Environment:

Linux


 Description   

When running mariadb tests on ppc32, server prints warning messages like this:

***Warnings generated in error logs during shutdown after running tests: main.plugin_load_option
 
130211  4:37:13 [Warning] setrlimit could not change the size of core files to 'infinity';  We may not be able to generate a core file on signals

Looking at mariadb-5.5.29/mysql-test/lib/v1/mtr_report.pl or http://bugs.mysql.com/bug.php?id=32080, these warnings should be ignored during test run, which is not true and test suite fails. It seems like the filtering of warning messages is never done at all.

Originally reported here: https://bugzilla.redhat.com/show_bug.cgi?id=906367

How to reproduce:
I don't have access to a ppc32 machine, but I reproduced this by patching mysqld.cc to throw the setrlimit warning unconditionally. Then running some tests fails as follows:

$ ./mysql-test-run --do-test rpl_create_tmp_table_if_not_exists
 
defined(@array) is deprecated at ./mysql-test-run line 554.
 
	(Maybe you should just omit the defined()?)
 
Logging: ./mysql-test-run  --do-test rpl_create_tmp_table_if_not_exists
 
Using suites: main-,archive-,binlog-,csv-,federated-,funcs_1-,funcs_2-,handler-,heap-,innodb-,maria-,optimizer_unfixed_bugs-,oqgraph-,parts-,percona-,perfschema-,plugins-,rpl-,sphinx-,sys_vars-,unit-,vcol-
 
vardir: /usr/share/mysql-test/var
 
Checking leftover processes...
 
Removing old var directory...
 
Creating var directory '/usr/share/mysql-test/var'...
 
Checking supported features...
 
130212 16:19:50 [Warning] setrlimit could not change the size of core files to 'infinity';  We may not be able to generate a core file on signals
 
MariaDB Version 5.5.29-MariaDB
 
Installing system database...
 
 - skipping ndbcluster
 
 - SSL connections supported
 
Collecting tests...
 
Using server port 54711
 
 
 
==============================================================================
 
 
 
TEST                                      RESULT   TIME (ms) or COMMENT
 
--------------------------------------------------------------------------
 
 
 
worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
 
rpl.rpl_create_tmp_table_if_not_exists 'mix' [ pass ]    551
 
rpl.rpl_create_tmp_table_if_not_exists 'row' [ skipped ]  Neither MIXED nor STATEMENT binlog format
 
***Warnings generated in error logs during shutdown after running tests: rpl.rpl_create_tmp_table_if_not_exists
 
 
 
130212 16:19:56 [Warning] setrlimit could not change the size of core files to 'infinity';  We may not be able to generate a core file on signals
 
130212 16:19:56 [Warning] setrlimit could not change the size of core files to 'infinity';  We may not be able to generate a core file on signals
 
 
 
 
 
Only  2  of 3 completed.
 
--------------------------------------------------------------------------
 
The servers were restarted 1 times
 
Spent 0.551 of 12 seconds executing testcases
 
 
 
Warnings in log: All 1 tests were successful.
 
 
 
Errors/warnings were found in logfiles during server shutdown after running the
 
following sequence(s) of tests:
 
    rpl.rpl_create_tmp_table_if_not_exists
 
1 tests were skipped, 1 by the test itself.
 
 
 
mysql-test-run: *** ERROR: There where errors/warnings in server logs after running test cases.



 Comments   
Comment by Elena Stepanova [ 2013-02-14 ]

Suggested fix – Sergei, if it's okay with you, I'll push it into 5.1:

=== modified file 'mysql-test/mysql-test-run.pl'
— mysql-test/mysql-test-run.pl 2012-08-22 09:40:39 +0000
+++ mysql-test/mysql-test-run.pl 2013-02-14 00:11:57 +0000
@@ -4448,6 +4448,7 @@
qr|Table '\..mtr.test_suppressions' is marked as crashed and should be repaired|,
qr|InnoDB: Error: table 'test/bug39438'|,
qr|table.*is full|,
+ qr|setrlimit could not change the size of core files to 'infinity';|,
);

my $matched_lines= [];

(The warnings were suppressed all right when tests were executed, but they appear even for skipped tests, and there suppression via global_suppressions table doesn't work.)

Comment by Sergei Golubchik [ 2013-02-14 ]

please, go ahead

Comment by Elena Stepanova [ 2013-02-14 ]

Pushed into maria/5.1 revno 3182. The fix should appear in the releases listed in 'Fix Version/s'.

Generated at Thu Feb 08 06:54:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.