[MDEV-4160] Add log_warnings_suppress option Created: 2013-02-09  Updated: 2022-07-30

Status: Open
Project: MariaDB Server
Component/s: None
Fix Version/s: None

Type: Task Priority: Minor
Reporter: Ryan Brothers Assignee: Oleksandr Byelkin
Resolution: Unresolved Votes: 5
Labels: None

Issue Links:
Relates
relates to MDEV-24850 Convert log_warnings from numeric lev... Open

 Description   

Would it be possible to add the log_warnings_suppress option that currently exists in Percona Server to suppress errors with a 1592 code from being logged? These errors are created for potentially unsafe statements for binary logging.

In my system, I need to use binlog_format=STATEMENT because I have triggers that run on a slave that do not exist on the master. Because of that, I ensure in advance that all queries I execute against my database are replication-safe even if MySQL logs it as potentially unsafe. When these queries are executed, my error logs fill up with replication unsafe errors even though my queries are replication-safe.

http://www.percona.com/doc/percona-server/5.5/flexibility/log_warnings_suppress.html

 Comments   
Comment by Ian Gilfillan [ 2018-03-16 ]

MySQL 5.7 has the log_statements_unsafe_for_binlog option, so Percona 5.7 has removed log_warnings_suppress.

Comment by Chris Calender (Inactive) [ 2019-01-18 ]

Per their documentation, they have not removed it:

https://www.percona.com/doc/percona-server/8.0/flexibility/log_warnings_suppress.html

The functionality is currently limited to the suppression of warning #1592 only (unsafe statement for binary logging), but they note that, "In the future, the ability to optionally disable additional warnings may also be added."

Irregardless of that, this would be a nice feature, for all/many/most warnings.

Comment by Chris Calender (Inactive) [ 2019-01-18 ]

Specifically looking to suppress warnings of the type:

2019-01-19 15:55:01 41 [Warning] IP address '192.168.0.1' could not be resolved: Name or service not known
2019-01-19 15:55:02 42 [Warning] IP address '192.168.0.2' could not be resolved: Name or service not known
2019-01-19 15:55:03 43 [Warning] IP address '192.168.0.3' could not be resolved: Name or service not known
2019-01-19 15:55:04 44 [Warning] IP address '192.168.0.4' could not be resolved: Name or service not known
2019-01-19 15:55:05 45 [Warning] IP address '192.168.0.5' could not be resolved: Name or service not known

Comment by Andrei Elkin [ 2019-03-06 ]

ralf.gebhardt@mariadb.com To my understanding the case was reported before
the patch of 8e4566e9123f Michael Widenius 2014-09-16 that tackles exclusively repeating replication unsafe warnings (#1592).
The recent followup extends the requirement to cover any repeating warnings and that goes beyond replication concern.
It sounds as a good idea, but we need the server level discussion of which approach to take.
Personally I think the syslog way of suppression duplicates is the best in our case.
Without a doubt serg can bring in more to consider.

Comment by Andrei Elkin [ 2019-03-27 ]

serg, the user asks for arbitrary warning repeated pattern suppression. In replication we have very custom solution to a specific code warning. Clearly a general method needs to be discussed with the architecture, could you please follow up with ideas/instructions.

Comment by Oleksandr Byelkin [ 2019-04-15 ]

1. Actually the mentioned error is not duplicate
2 It has no number to filter by it (and we have a lot of such warning, half of them should be fixed
3 should error be filtered by:
3.1 number
3.2 text
4 should filter be for each thread or global

Generated at Thu Feb 08 06:54:15 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.