[MDEV-4050] apply a patch for MySQL bug#12694872 Created: 2013-01-15 Updated: 2014-11-26 |
|
| Status: | Open |
| Project: | MariaDB Server |
| Component/s: | None |
| Affects Version/s: | N/A |
| Fix Version/s: | 5.5 |
| Type: | Bug | Priority: | Major |
| Reporter: | Sergei Golubchik | Assignee: | Sergei Petrunia |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
| Description |
|
MySQL 5.5.29 has a patch backported from MySQL 5.6, that supposedly fixes a bug. The test case for this bugfix is wrong, it doesn't exercise the changed code. We need to fix the test case to see if there's a genuine bug, and apply the MySQL fix, if it's good. The patch is attached. |
| Comments |
| Comment by Sergei Petrunia [ 2014-02-10 ] | ||||||||||||||||||||||||||
|
"Changeset in 5.5 with the test case" is actually in 5.6 | ||||||||||||||||||||||||||
| Comment by Sergei Petrunia [ 2014-02-10 ] | ||||||||||||||||||||||||||
|
If I take the cset "tor.didriksen@oracle.com-20110825105434-ll28zinu0nhazt3z", undo the changes in sql_select.cc (so that changes in other files remain, we get the added asserts and new testcases), and after that run the testsuite, I get: mysqld: /home/psergey/dev2/mysql-5.6-r3404/sql/uniques.cc:587: bool Unique::get(TABLE*): Assertion `table->sort.record_pointers == __null' failed. | ||||||||||||||||||||||||||
| Comment by Sergei Petrunia [ 2014-02-10 ] | ||||||||||||||||||||||||||
|
If I
| ||||||||||||||||||||||||||
| Comment by Sergei Petrunia [ 2014-02-11 ] | ||||||||||||||||||||||||||
|
There is another bugfix that is related to MySQL BUG#12694872: Bug#13340270: assertion table->sort.record_pointers == __null bug#12694872 fixed a memory leak in Unique::get(), but did not expect | ||||||||||||||||||||||||||
| Comment by Elena Stepanova [ 2014-11-26 ] | ||||||||||||||||||||||||||
|
For a note, we have a 5.3 bug apparently with a similar valgrind warning:
However, I am not getting the valgrind failure with it on a prefixed MySQL 5.5/5.6, so I guess it's not exactly the same. |