[MDEV-399] Combinations defined in the base suite cannot be skipped by overlay Created: 2012-07-17 Updated: 2012-08-01 Resolved: 2012-08-01 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | None |
| Affects Version/s: | 5.5.25 |
| Fix Version/s: | 5.5.27 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Elena Stepanova | Assignee: | Sergei Golubchik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tests | ||
| Description |
|
The binlog suite already has a combinations file, which defines three combinations: row, mix, stmt. We will be working with it. cd <basedir>/mysql-test Create an overlay for the binlog suite for MyISAM: mkdir -p ../storage/myisam/mysql-test/binlog Run the test to make sure that combinations still work: perl ./mtr --suite=binlog-myisam binlog_server_id
Add suite.pm in the overlay:
Run the test again: perl ./mtr --suite=binlog-myisam binlog_server_id
Didn't work – mix is still there. Add its own combinations file in the overlay: vi ../storage/myisam/mysql-test/binlog/combinations
Run the test again: perl ./mtr --suite=binlog-myisam binlog_server_id
The combinations file in overlay works. Try to disable one of the suite's custom combinations: vi ../storage/myisam/mysql-test/binlog/suite.pm
perl ./mtr --suite=binlog-myisam binlog_server_id
This worked, so it's not like our subroutine is bad, or something; but 'mix' is still there. Possibly the combinations file should be somehow specified with a prefix in the suite.pm (in the hash key), but I haven't found a way to do so, neither by trying nor by reading the code, although maybe I didn't dig deep enough. |