[MDEV-3862] Lift limitation for merging VIEWS with Subqueries in SELECT_LIST and test it Created: 2012-11-16  Updated: 2012-12-17  Resolved: 2012-12-17

Status: Closed
Project: MariaDB Server
Component/s: None
Fix Version/s: 10.0.2

Type: Task Priority: Major
Reporter: Oleksandr Byelkin Assignee: Oleksandr Byelkin
Resolution: Fixed Votes: 0
Labels: None


 Description   

Also see http://ru-mysql.livejournal.com/287623.html?nojs=1

Patch is like this (+ variable to control)

bell@desktop:~/maria/bzr/work-maria-5.5-test/mysql-test$ bzr diff
=== modified file 'sql/sql_lex.cc'
— sql/sql_lex.cc 2012-08-27 16:13:17 +0000
+++ sql/sql_lex.cc 2012-11-16 09:48:33 +0000
@@ -2578,6 +2578,7 @@ bool LEX::can_be_merged()
if (tmp_unit->first_select()->parent_lex == this &&
(tmp_unit->item == 0 ||
(tmp_unit->item->place() != IN_WHERE &&
+ tmp_unit->item->place() != SELECT_LIST &&
tmp_unit->item->place() != IN_ON)))
{
selects_allow_merge= 0;

then use random Query Generator to test it.

 Comments   
Comment by Oleksandr Byelkin [ 2012-11-19 ]

Looking on test cases and manual it looks like test for merge was mixed with test for updateability in this case.

Comment by Oleksandr Byelkin [ 2012-12-12 ]

pushed

Generated at Thu Feb 08 06:51:50 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.