Re: [Bug 712720] [NEW] handlersocket does not compile against MariaDB 5.3
Hi, Philip!

we have a plug.in file for handlersocket that allows to build it from
within the source tree. It solves this problem.

On Feb 03, Philip Stoev wrote:
> Public bug reported:
>
> Even after working around bug 712714 , handlersocket does not compile
> against maria-5.3
>
> To repeat, configure handlersocket
>
> ./configure -with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB
> alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/
>
> then run "make" and you will get
>
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ?void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)?:
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ?virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)? is protected
> database.cpp:793: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ?virtual int handler::index_prev(uchar*)? is protected
> database.cpp:798: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ?virtual int handler::index_next(uchar*)? is protected
> database.cpp:802: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ?virtual int handler::index_next_same(uchar*, const uchar*, uint)? is protected
> database.cpp:805: error: within this context
> make[2]: *** [handlersocket_la-database.lo] Error 1
>
> ** Affects: maria
> Importance: Undecided
> Status: New
>
> ** Changed in: maria
> Milestone: None => 5.3
>
> ** Branch linked: lp:~maria-captains/maria/5.3-handler
>
> –
> You received this bug notification because you are a member of Maria-
> captains, which is the registrant for Maria.
> https://bugs.launchpad.net/bugs/712720
>
> Title:
> handlersocket does not compile against MariaDB 5.3
>
> Status in Maria:
> New
>
> Bug description:
> Even after working around bug 712714 , handlersocket does not compile
> against maria-5.3
>
> To repeat, configure handlersocket
>
> ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0
> MariaDB-alpha --with-mysql
> bindir=/home/philips/bzr/maria-5.3-bintar/bin/
>
> then run "make" and you will get
>
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ?void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)?:
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ?virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)? is protected
> database.cpp:793: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ?virtual int handler::index_prev(uchar*)? is protected
> database.cpp:798: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ?virtual int handler::index_next(uchar*)? is protected
> database.cpp:802: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ?virtual int handler::index_next_same(uchar*, const uchar*, uint)? is protected
> database.cpp:805: error: within this context
> make[2]: *** [handlersocket_la-database.lo] Error 1
>
>
>
Regards,
Sergei

Re: handlersocket does not compile against MariaDB 5.3
I think we should still provide a patch for the main handlersocket tree so that it compiles properly with MariaDB.

Re: handlersocket does not compile against MariaDB 5.3
plug.in file and all necessary changes

plug.in file and all necessary changes
handlersocket.diff
LPexportBug712720_handlersocket.diff

Re: handlersocket does not compile against MariaDB 5.3
Patch does not work against the latest handlersocket:

Re: handlersocket does not compile against MariaDB 5.3
nevermind it worked with -p2

Re: handlersocket does not compile against MariaDB 5.3
If -Werror is enabled, as it is by the ./BUILD/compile-pentium-debug-max-no-ndb script, we get:

(13:29:42) philip_stoev1: "cc1plus: warnings being treated as errors
(13:29:42) philip_stoev1: In file included from socket.hpp:15,
(13:29:42) philip_stoev1: from socket.cpp:18:
(13:29:42) philip_stoev1: auto_addrinfo.hpp: In member function ‘int dena::auto_addrinfo::resolve(const char*, const char*, int, int, int, int)’:
(13:29:42) philip_stoev1: auto_addrinfo.hpp:35: error: missing initializer for member ‘addrinfo::ai_flags’"

Re: handlersocket does not compile against MariaDB 5.3
Hi,

Where can I find the plug.in file and instructions on how to patch it. I'm trying to build it against mariadb 5.2.5 and I am receiving the same error.

Thanks

Re: [Bug 712720] Re: handlersocket does not compile against MariaDB 5.3
Hi, Jason!

On Apr 18, Jason wrote:
> Hi,
>
> Where can I find the plug.in file and instructions on how to patch it.
> I'm trying to build it against mariadb 5.2.5 and I am receiving the same
> error.

See, the bug report has "Status: Fix Committed", and "Milestone: Maria 5.3".
Which means, you can find the files in 5.3 mariadb tree.

http://bazaar.launchpad.net/~maria-captains/maria/5.3/files

Regards,
Sergei

Launchpad bug id: 712720