[MDEV-3693] LP:612832 - MariaDB Won't Compile in Cygwin - Patch Attached Created: 2010-08-03  Updated: 2012-10-04  Resolved: 2012-10-04

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Trivial
Reporter: Larry Adams (Inactive) Assignee: Michael Widenius
Resolution: Won't Fix Votes: 0
Labels: Launchpad

Attachments: XML File LPexportBug612832.xml    

 Description   

Simple issue in the command line tools. MySQL claims they don't officially support Cygwin and closed the bug, even though there are hundreds of #ifdef's referencing Cygwin already. Bah!

— vi.c.orig 2010-07-31 08:31:06.047354500 -0400
+++ vi.c 2010-07-31 08:29:42.095897000 -0400
@@ -914,14 +914,14 @@

  • NB: posix implies that we should enter insert mode, however
  • this is against historical precedent...
    */
    -#if defined(_weak_reference) && !defined(FreeBSD_)
    +#if defined(_weak_reference) && !defined(FreeBSD) && !defined(CYGWIN_)
    extern char *get_alias_text(const char *) __weak_reference(get_alias_text);
    #endif
    protected el_action_t
    /ARGSUSED/
    vi_alias(EditLine *el, int c)
    {
    -#if defined(_weak_reference) && !defined(FreeBSD_)
    +#if defined(_weak_reference) && !defined(FreeBSD) && !defined(CYGWIN_)
    char alias_name[3];
    char *alias_text;

http://bugs.mysql.com/bug.php?id=55660&error=no

I don't think I'm being fair.

 Comments   
Comment by Bo Thorsen (Inactive) [ 2010-08-18 ]

Re: MariaDB Won't Compile in Cygwin - Patch Attached
Thanks for the patch, I'll test it and apply. It will take a bit of time, though, as I'm just back from vacation and pretty swamped with work over the next week or so.

Comment by Sergei Golubchik [ 2010-11-30 ]

Re: MariaDB Won't Compile in Cygwin - Patch Attached
what problem does cygwin has with these lines?
why do you need to add && !defined(_CYGWIN_) ?

Comment by Larry Adams (Inactive) [ 2010-12-01 ]

Re: [Bug 612832] Re: MariaDB Won't Compile in Cygwin - Patch Attached
Sergei,

I'll send make output. It's behaving identical to FreeBSD though. The
parameter count it wrong. There are other compile problems too. It's
related to the new storage engine's. I don't have the details at the
moment, and am away from my dev environment for the next several days.

Larry

On 11/30/2010 11:15 AM, Sergei wrote:
> what problem does cygwin has with these lines?
> why do you need to add&& !defined(_CYGWIN_) ?
>

Comment by Michael Widenius [ 2012-03-28 ]

Re: MariaDB Won't Compile in Cygwin - Patch Attached
This bug doesn't apply to MariaDB anymore as we never build with the bundled libedit.

Comment by Rasmus Johansson (Inactive) [ 2012-03-28 ]

Launchpad bug id: 612832

Generated at Thu Feb 08 06:50:31 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.